Check for null and empty strings for request properties.

braintree · Dec 6, 2024 · 073938b · 073938b
1 parent 152b11e
commit 073938b
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/Demo/src/main/java/com/braintreepayments/demo/PayPalRequestFactory.java b/Demo/src/main/java/com/braintreepayments/demo/PayPalRequestFactory.java
@@ -31,7 +31,7 @@ public static PayPalVaultRequest createPayPalVaultRequest(
 
         PayPalVaultRequest request = new PayPalVaultRequest(true);
 
-        if (buyerEmailAddress != null && !buyerEmailAddress.isEmpty() ) {
+        if (buyerEmailAddress != null && !buyerEmailAddress.isEmpty()) {
             request.setUserAuthenticationEmail(buyerEmailAddress);
         }
 
@@ -126,15 +126,19 @@ public static PayPalCheckoutRequest createPayPalCheckoutRequest(
     ) {
         PayPalCheckoutRequest request = new PayPalCheckoutRequest(amount, true);
 
-        if (buyerEmailAddress != null) {
+        if (buyerEmailAddress != null && !buyerEmailAddress.isEmpty()) {
             request.setUserAuthenticationEmail(buyerEmailAddress);
         }
 
-        if (buyerPhoneCountryCode != null && buyerPhoneNationalNumber != null) {
-            request.setUserPhoneNumber(new PayPalPhoneNumber(buyerPhoneCountryCode, buyerPhoneNationalNumber));
+        if ((buyerPhoneCountryCode != null && !buyerPhoneCountryCode.isEmpty())
+                && (buyerPhoneNationalNumber != null && !buyerPhoneNationalNumber.isEmpty())) {
+            request.setUserPhoneNumber(new PayPalPhoneNumber(
+                    buyerPhoneCountryCode,
+                    buyerPhoneNationalNumber)
+            );
         }
 
-        if (shopperInsightsSessionId != null) {
+        if (shopperInsightsSessionId != null && !shopperInsightsSessionId.isEmpty()) {
             request.setShopperSessionId(shopperInsightsSessionId);
         }