Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make chain selector component config agnostic #795

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

albertfolch-redeemeum
Copy link
Collaborator

@albertfolch-redeemeum albertfolch-redeemeum commented Sep 23, 2024

this is to allow this component to be used by fermion with a different config object type

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (c0ce9b9) to head (6756dc7).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
- Coverage   90.11%   90.02%   -0.09%     
==========================================
  Files         162      163       +1     
  Lines        6009     6057      +48     
  Branches      915      928      +13     
==========================================
+ Hits         5415     5453      +38     
- Misses        594      604      +10     
Flag Coverage Δ
common 92.11% <ø> (ø)
core-sdk 57.96% <ø> (+0.13%) ⬆️
e2e 87.22% <ø> (-0.09%) ⬇️
eth-connect-sdk 97.33% <ø> (ø)
ethers-sdk 70.03% <ø> (ø)
ipfs-storage 89.41% <ø> (-1.26%) ⬇️
metadata 94.70% <ø> (ø)
unittests 61.59% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertfolch-redeemeum albertfolch-redeemeum merged commit d8b537b into main Sep 23, 2024
10 of 12 checks passed
@albertfolch-redeemeum albertfolch-redeemeum deleted the make-chainselector-config-agnostic branch September 23, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant