Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate subgraph to 0xgraph #784

Merged
merged 20 commits into from
Nov 19, 2024
Merged

Conversation

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (c0ce9b9) to head (112850f).
Report is 98 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
+ Coverage   90.11%   90.26%   +0.15%     
==========================================
  Files         162      163       +1     
  Lines        6009     6061      +52     
  Branches      915      927      +12     
==========================================
+ Hits         5415     5471      +56     
+ Misses        594      590       -4     
Flag Coverage Δ
common 92.11% <ø> (ø)
core-sdk 59.50% <ø> (+1.67%) ⬆️
e2e 87.19% <ø> (-0.12%) ⬇️
eth-connect-sdk 94.87% <ø> (-2.47%) ⬇️
ethers-sdk 69.62% <ø> (-0.41%) ⬇️
ipfs-storage 89.41% <ø> (-1.26%) ⬇️
metadata 94.70% <ø> (ø)
unittests 62.91% <ø> (+1.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ levalleux-ludo
❌ github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@levalleux-ludo levalleux-ludo marked this pull request as ready for review November 19, 2024 13:37
@@ -2,21 +2,21 @@ name: Deploy subgraph to testing env

on:
workflow_dispatch:
branches: [main]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why dont we keep this to force redeploying?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO the branches option on the workflow_dispatch event is not correct (never mentionned in the GH docs: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_dispatch).
The idea having workflow_dispatch is to allow running the job with a manual trigger and it's always possible to choose the branch there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the other event is the one that is trigerring the job when there is a push on main branch with changes in the subgraph package

push:
    branches:
      - 'main'
    paths:
      - packages/subgraph/**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants