-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate subgraph to 0xgraph #784
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #784 +/- ##
==========================================
+ Coverage 90.11% 90.26% +0.15%
==========================================
Files 162 163 +1
Lines 6009 6061 +52
Branches 915 927 +12
==========================================
+ Hits 5415 5471 +56
+ Misses 594 590 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…ds (testing only)
|
@@ -2,21 +2,21 @@ name: Deploy subgraph to testing env | |||
|
|||
on: | |||
workflow_dispatch: | |||
branches: [main] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why dont we keep this to force redeploying?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO the branches
option on the workflow_dispatch
event is not correct (never mentionned in the GH docs: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_dispatch).
The idea having workflow_dispatch
is to allow running the job with a manual trigger and it's always possible to choose the branch there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the other event is the one that is trigerring the job when there is a push on main branch with changes in the subgraph package
push:
branches:
- 'main'
paths:
- packages/subgraph/**
Description
How to test
{{how can it be tested}}