fix: bundler relies on eth_getLogs with indefinite range #855

souradeep-das · 2023-05-26T19:22:58Z

📋 https://github.com/bobanetwork/boba/issues/843 #866

Overview

Fixes bundler reliance on eth_getLogs with range > 5000

Changes

bundler splits eth_getLogs requests if the range to request is > 5k
a new config 'l1Offset' has been added to bundler, to allow the bundler to start watching from a specific block
adds opts {fromBlock and toBlock} for eth_getUserOperationReceipt and eth_getUserOperationByHash

Testing

circleci logs

packages/boba/bundler/src/modules/EventsManager.ts

packages/boba/bundler/src/BundlerServer.ts

packages/boba/bundler/src/modules/EventsManager.ts

souradeep-das · 2023-05-31T15:57:51Z

packages/boba/bundler/src/modules/EventsManager.ts

-    readonly reputationManager: ReputationManager
-  ) {}
+    readonly reputationManager: ReputationManager,
+    readonly l1Offset: number


woops I'll change this to l2Offset and make "5000" configurable

souradeep-das · 2023-05-31T17:41:06Z

converted the log chunksize to a configurable value, please review the last two commits. (associated docs updated here https://github.com/bobanetwork/boba/pull/867)

wsdt · 2023-06-01T11:17:41Z

packages/boba/bundler/src/UserOpMethodHandler.ts

@@ -227,11 +227,14 @@ export class UserOpMethodHandler {
  }

  async _getUserOperationEvent(
-    userOpHash: string
+    userOpHash: string,
+    opts?: any


Should we add a type for this?

wsdt

left a comment, looks good

* fix: workaround for bundler eth_getLogs range * remove unused deps * fix: rename to l2Offset * add configurable logsChunckSize --------- Co-authored-by: Riedl Kevin, Bsc <kevin.riedl@wavect.io> (cherry picked from commit 13a1222)

* Add exit dumper (#806) * Add exit dumper * Bump up go version * Fix go lint (cherry picked from commit b3a6b06) * Fix: gateway horizontal scrollbar. (#821) (cherry picked from commit b23ab2b) * added release-please (#823) * added release-please * Update release-please.yml * on push develop, default master (cherry picked from commit 4eb3c9c) * [AA] fix UserOpMethodHandler estimateUserOperationGas #752 (#756) * userop-estimateUserOperationGas * fix-integ-test * add-bundler-utils * rmlock * integration test * bundler-main * lock rm integration test debugging bundler-main * Update integration-tests/test/eth-l2/boba_aa_bundler.spec.ts Co-authored-by: Ino Murko <ino.murko.github@protonmail.com> * Update UserOpMethodHandler.ts * debugging * bundlerProvider * wallets * test fixed * alt * rm only * dep * bnb tests * Update boba_aa_bundler.spec.ts * feedback * failedop status status merge fix-mapping * resp * undo-package --------- Co-authored-by: Ino Murko <ino.murko.github@protonmail.com> (cherry picked from commit 4a31038) * remove rinkeby|ropsten with goerli (#834) (cherry picked from commit 9a5991b) * make hosted and AM names consistent (#839) (cherry picked from commit 8de8f2a) * message for swap (#825) (cherry picked from commit 2e7abf3) * Deploy audit contracts to testnets (#841) * Deploy audit contracts to Goerli * Deploy audit contracts to BSC testnet * Deploy audit contracts to Fuji * Deploy audit contracts to Opera testnet and bobabase (cherry picked from commit 77aaa9d) * [AA] test: add more paymaster ownership tests (#810) * test: add paymaster ownership tests * fix: alt-l1 tests * add gaslimit (cherry picked from commit 7ef780d) * Fix : Alert for Boba Opera shutting down (#814) * fantom opera disable alert + textual change for moonbeam alert * updated test cases for notification banner * updated dates for the opera shutdown * updated test cases * updated test cases failure (cherry picked from commit f949b70) * Bump @openzeppelin/contracts-upgradeable (#840) (cherry picked from commit 92e1688) * install yq (#844) build all side containers release building containers (cherry picked from commit 1c17ac3) * Bump undici from 5.14.0 to 5.22.1 (#850) Bumps [undici](https://github.com/nodejs/undici) from 5.14.0 to 5.22.1. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.14.0...v5.22.1) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit d443e83) * Bump cookiejar from 2.1.3 to 2.1.4 (#848) Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.3 to 2.1.4. - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 3200612) * Add Snyk, Dependabot, Secretfinder (#838) * Create dependabot.yml * Update dependabot.yml * snyk * secret-detect * build(detect-secrets): Commit the newly-generated .secrets.baseline file * error on * fix-vulnerabilities * snyk * integ * Update package.json * Update package.json * Update package.json * Update snyk.yml * Update secret-detect.yml * Update .github/dependabot.yml Co-authored-by: Ino Murko <ino.murko.github@protonmail.com> --------- Co-authored-by: wsdt <wsdt@users.noreply.github.com> Co-authored-by: Ino Murko <ino.murko.github@protonmail.com> (cherry picked from commit 19b2367) * Fix dependabot (reviewers) intendation (#853) (cherry picked from commit 3e84e29) * Revert "Fix dependabot (reviewers) intendation" (#854) * Revert "Fix dependabot (reviewers) intendation (#853)" This reverts commit 3e84e29. * Update dependabot.yml --------- Co-authored-by: Riedl Kevin, Bsc <kevin.riedl@wavect.io> (cherry picked from commit 276eb71) * Bump @types/chai from 4.3.4 to 4.3.5 (#859) Bumps [@types/chai](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/chai) from 4.3.4 to 4.3.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/chai) --- updated-dependencies: - dependency-name: "@types/chai" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit f3f78df) * Bump typedoc from 0.22.18 to 0.24.7 (#858) Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.22.18 to 0.24.7. - [Release notes](https://github.com/TypeStrong/TypeDoc/releases) - [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md) - [Commits](TypeStrong/typedoc@v0.22.18...v0.24.7) --- updated-dependencies: - dependency-name: typedoc dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 0b8938e) * Bump prettier and @types/prettier (#857) Bumps [prettier](https://github.com/prettier/prettier) and [@types/prettier](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/prettier). These dependencies needed to be updated together. Updates `prettier` from 2.8.2 to 2.8.8 - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.8.2...2.8.8) Updates `@types/prettier` from 2.2.1 to 2.7.2 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/prettier) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: "@types/prettier" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit ee80d8c) * Bump @emotion/react from 11.10.6 to 11.11.0 (#856) Bumps [@emotion/react](https://github.com/emotion-js/emotion) from 11.10.6 to 11.11.0. - [Release notes](https://github.com/emotion-js/emotion/releases) - [Changelog](https://github.com/emotion-js/emotion/blob/main/CHANGELOG.md) - [Commits](https://github.com/emotion-js/emotion/compare/@emotion/react@11.10.6...@emotion/react@11.11.0) --- updated-dependencies: - dependency-name: "@emotion/react" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 2b559d3) * Bump http-cache-semantics from 4.1.0 to 4.1.1 (#849) Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 2d84ebb) * Verifier fixes (#835) * Pin web3.py dependency to last working version (v6.x has incompatible changes) Changes to be committed: modified: boba_community/fraud-detector/docker/Dockerfile.fraud-detector * Update the verifier docker-compose.yml structure to match the replica (../boba-node/docker-compose.yml). Changes to be committed: modified: docker-compose.yml * Move addresses.json file (mainnet) Changes to be committed: renamed: addresses.json -> addresses/mainnet/addresses.json * Avoid expensive queries to AddressManager contract by returning values from the configured addressList. Assumes that contract addresses do not change after deployment (within the relevant range of blocks). Changes to be committed: modified: packages/data-transport-layer/src/services/l1-ingestion/service.ts modified: packages/data-transport-layer/src/services/main/service.ts * Add Goerli files. Changes to be committed: new file: docker-compose-goerli.yml new file: state-dumps/goerli/addresses.json new file: state-dumps/goerli/boba-addr.json new file: state-dumps/goerli/state-dump.latest.json renamed: addresses/mainnet/addresses.json -> state-dumps/mainnet/addresses.json * Add Verifier / Fraud Detector support for the legacy mainnet prior to the regenesis. Changes to be committed: new file: docker-compose-v1_mainnet.yml modified: docker-compose.yml modified: fraud-detector.py new file: state-dumps/v1_mainnet/addresses.json new file: state-dumps/v1_mainnet/state-dump.latest.json * Update documentation; fix V1 contract names. Changes to be committed: modified: README.md modified: state-dumps/v1_mainnet/addresses.json * Fixes. Changes to be committed: modified: README.md modified: docker-compose-goerli.yml modified: docker-compose.yml --------- Co-authored-by: Ino Murko <ino.murko.github@protonmail.com> (cherry picked from commit 10f0e3a) * Add more information to Bundler SDK release & versioning (#813) * fix npm versioning * branch * changed-refspec * push * define-branch * Bump Bundler SDK version * path-filters define-branch push changed-refspec branch fix npm versioning * package metadata, docs finish actions trigger-change trigger-change fix-test-branch switch-actions * yarn.lcok * trigger * Bump Bundler SDK version * fix-lock * fix-lock * works test ghtok dev version test trigger trigger trigger trigger has-updated * Update .github/workflows/aa-bundler-sdk-pr.yml Co-authored-by: Ino Murko <ino.murko.github@protonmail.com> * Update aa-bundler-sdk-pr.yml * Update aa-bundler-sdk.yml * open a PR * update tags * check if packages *was* updated * set base branch for new PR * use GH_PERSONAL_ACCESS_TOKEN instead of GITHUB_TOKEN * use yarn instead of npm * use yarn with jq * use action-bump-semver * run only on merge to develop when theres a change --------- Co-authored-by: GitHub Actions Bot <> Co-authored-by: Ino Murko <ino.murko.github@protonmail.com> Co-authored-by: Ino Murko <2582555+InoMurko@users.noreply.github.com> (cherry picked from commit 2f6f8fe) * Github: CI/CD for gateway deployment to staging. (#824) * testing tag version * update yml * prepare the github workflow for deploy to stage & cleanup unused workflow * env params value * cleanup keys & script from package.json (cherry picked from commit fc0dee7) * Gateway CI/CD : workflow fixes (#863) * workflow fixes * removed linting, added working directory while sync with s3 (cherry picked from commit 00c586e) * Update SDK version (#862) Co-authored-by: InoMurko <InoMurko@users.noreply.github.com> Co-authored-by: Riedl Kevin, Bsc <kevin.riedl@wavect.io> (cherry picked from commit 3ef009a) * fix: bundler relies on eth_getLogs with indefinite range (#855) * fix: workaround for bundler eth_getLogs range * remove unused deps * fix: rename to l2Offset * add configurable logsChunckSize --------- Co-authored-by: Riedl Kevin, Bsc <kevin.riedl@wavect.io> (cherry picked from commit 13a1222) --------- Co-authored-by: Boyuan-Chen <46272347+Boyuan-Chen@users.noreply.github.com> Co-authored-by: Sahil K <86316370+sk-enya@users.noreply.github.com> Co-authored-by: Riedl Kevin, Bsc <kevin.riedl@wavect.io> Co-authored-by: Souradeep Das <dsouradeep2@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Montour <mmontour@enya.ai> Co-authored-by: bobabot-enya-ai <101345210+bobabot-enya-ai@users.noreply.github.com>

fix: workaround for bundler eth_getLogs range

e1786af

souradeep-das commented May 26, 2023

View reviewed changes

packages/boba/bundler/src/modules/EventsManager.ts Outdated Show resolved Hide resolved

souradeep-das requested review from InoMurko and wsdt May 26, 2023 19:24

remove unused deps

937ec8a

InoMurko suggested changes May 30, 2023

View reviewed changes

packages/boba/bundler/src/BundlerServer.ts Show resolved Hide resolved

packages/boba/bundler/src/modules/EventsManager.ts Outdated Show resolved Hide resolved

souradeep-das marked this pull request as ready for review May 30, 2023 13:08

souradeep-das commented May 31, 2023

View reviewed changes

InoMurko approved these changes May 31, 2023

View reviewed changes

souradeep-das added 2 commits May 31, 2023 22:04

fix: rename to l2Offset

b761a19

add configurable logsChunckSize

b171308

Merge branch 'develop' into souradeep/bundler_getLogs

6da541a

wsdt reviewed Jun 1, 2023

View reviewed changes

wsdt approved these changes Jun 1, 2023

View reviewed changes

Merge branch 'develop' into souradeep/bundler_getLogs

51328fa

InoMurko merged commit 13a1222 into develop Jun 1, 2023

InoMurko deleted the souradeep/bundler_getLogs branch June 1, 2023 11:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: bundler relies on eth_getLogs with indefinite range #855

fix: bundler relies on eth_getLogs with indefinite range #855

souradeep-das commented May 26, 2023 •

edited

Loading

souradeep-das May 31, 2023

souradeep-das commented May 31, 2023

wsdt Jun 1, 2023

wsdt left a comment

fix: bundler relies on eth_getLogs with indefinite range #855

fix: bundler relies on eth_getLogs with indefinite range #855

Conversation

souradeep-das commented May 26, 2023 • edited Loading

Overview

Changes

Testing

souradeep-das May 31, 2023

Choose a reason for hiding this comment

souradeep-das commented May 31, 2023

wsdt Jun 1, 2023

Choose a reason for hiding this comment

wsdt left a comment

Choose a reason for hiding this comment

souradeep-das commented May 26, 2023 •

edited

Loading