Fix/upload json file (#554)

* chore: Upgrade superagent * chore: Upgrade superagent's type * fix: Upload JSON file
bnb-chain · May 31, 2024 · 64a62b1 · 64a62b1
1 parent 09ed37d
commit 64a62b1
Show file tree

Hide file tree

Showing 4 changed files with 15,104 additions and 9,960 deletions.
diff --git a/.changeset/violet-news-smell.md b/.changeset/violet-news-smell.md
@@ -0,0 +1,5 @@
+---
+'@bnb-chain/greenfield-js-sdk': patch
+---
+
+fix: Upload file that `content-type` is `application/json`, cancel serialize.
diff --git a/packages/js-sdk/package.json b/packages/js-sdk/package.json
@@ -70,6 +70,7 @@
     "@ethersproject/units": "^5.7.0",
     "@metamask/eth-sig-util": "^5.0.2",
     "@noble/curves": "^1.3.0",
+    "browser-or-node": "^3.0.0",
     "cross-fetch": "^4.0.0",
     "dayjs": "^1.11.7",
     "ethereum-cryptography": "^2.0.0",
@@ -82,7 +83,7 @@
     "long": "^5.2.1",
     "mime-types": "^2.1.35",
     "reflect-metadata": "^0.1.13",
-    "superagent": "^8.1.2",
+    "superagent": "^9.0.2",
     "tsyringe": "^4.8.0"
   },
   "devDependencies": {
@@ -96,7 +97,7 @@
     "@types/lodash.sortby": "^4.7.7",
     "@types/mime": "^3.0.1",
     "@types/mime-types": "^2.1.4",
-    "@types/superagent": "^8.1.6",
+    "@types/superagent": "^8.1.7",
     "@types/xml2js": "^0.4.11",
     "dotenv": "^16.0.3",
     "jest": "^29.5.0",

diff --git a/packages/js-sdk/src/clients/spclient/spClient.ts b/packages/js-sdk/src/clients/spclient/spClient.ts
@@ -20,6 +20,7 @@ import { getGetObjectMetaInfo } from './spApis/getObject';
 import { getPutObjectMetaInfo } from './spApis/putObject';
 import { assertFileType, assertHttpMethod } from '@/utils';
 import { UploadFile } from '@/types/sp/Common';
+import { isNode } from 'browser-or-node';
 
 export interface ISpClient {
   callApi(
@@ -168,6 +169,7 @@ export class SpClient implements ISpClient {
     },
   ) {
     const R = superagent.put(url);
+    R.buffer(true);
     R.timeout(timeout);
     R.ok((res) => res.status < 500);
 
@@ -178,11 +180,6 @@ export class SpClient implements ISpClient {
     }
 
     try {
-      const R = superagent.put(url);
-      R.buffer(true);
-      R.timeout(timeout);
-      R.ok((res) => res.status < 500);
-
       if (options.headers) {
         (options.headers as Headers).forEach((v: string, k: string) => {
           R.set(k, v);
@@ -196,7 +193,11 @@ export class SpClient implements ISpClient {
       }
 
       const file = assertFileType(uploadFile) ? uploadFile.content : uploadFile;
-      const response = await R.send(file);
+
+      // https://ladjs.github.io/superagent/docs/index.html#serializing-request-body
+      const serializeFile =
+        isNode && R.get('Content-Type') === 'application/json' ? file.toString() : file;
+      const response = await R.send(serializeFile);
       const { status } = response;
 
       if (status === SP_NOT_AVAILABLE_ERROR_CODE) {