Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go to 1.22 and dependencies #386

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Upgrade go to 1.22 and dependencies #386

merged 2 commits into from
Apr 12, 2024

Conversation

splaspood
Copy link
Collaborator

What does this PR implement/change/remove?

Upgrade from go 1.18 to 1.22.

Description for changelog/release notes

Upgrade to go 1.22 as well as refresh of deps.

@splaspood
Copy link
Collaborator Author

@jacobweinstock @chrisdoherty4 Wanted to run this PR past you folks since I'm told rufio has a dependency on bmclib.

@jacobweinstock
Copy link
Member

Hey @splaspood , other than the failed checks this seems good to me. Thanks!

jacobweinstock
jacobweinstock previously approved these changes Apr 11, 2024
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a minor CI suggestion, and typecheck has a few errors

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@splaspood splaspood merged commit 7b6b567 into main Apr 12, 2024
5 checks passed
@splaspood splaspood deleted the upgrade-go-0 branch April 12, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants