Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve SEL in both opinionated and raw formats #375

Closed
wants to merge 4 commits into from

Conversation

mattcburns
Copy link
Contributor

What does this PR implement/change/remove?

This PR adds the ability to retrieve the System Event Log from the target BMC using either IPMI or Redfish. There is an opinionated method that returns the entries as an array of entries in array format and a raw method that returns the raw output from the BMC.

Checklist

  • Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

N/A

The HW model number, product name this change applies to (if applicable)

N/A

The BMC firmware and/or BIOS versions that this change applies to (if applicable)

N/A

What version of tooling - vendor specific or opensource does this change depend on (if applicable)

N/A

Description for changelog/release notes

Added GetSystemEventLog and GetSystemEventLogRaw. These methods retrieve the SEL of the target BMC. The former uses an opinionated format, retrieving the ID, Timestamp, Description, Message in an array format. The latter returns the raw output as a string. Both IPMI and Redfish are supported.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (0df7b75) 43.87% compared to head (6659f34) 43.93%.

Files Patch % Lines
internal/redfishwrapper/sel.go 0.00% 43 Missing ⚠️
bmc/sel.go 76.62% 15 Missing and 3 partials ⚠️
client.go 0.00% 8 Missing ⚠️
providers/ipmitool/ipmitool.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   43.87%   43.93%   +0.06%     
==========================================
  Files          59       59              
  Lines        5042     5178     +136     
==========================================
+ Hits         2212     2275      +63     
- Misses       2608     2678      +70     
- Partials      222      225       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Clipped one line too high when fixing the conflicts earlier
@mattcburns mattcburns marked this pull request as ready for review November 29, 2023 16:44
@mattcburns mattcburns closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant