[1/3] Redfishwrapper changes #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoctorVin
reviewed
Nov 7, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 44.46% 44.99% +0.52%
==========================================
Files 56 60 +4
Lines 4421 5025 +604
==========================================
+ Hits 1966 2261 +295
- Misses 2238 2508 +270
- Partials 217 256 +39
☔ View full report in Codecov by Sentry. |
2 tasks
Since we need to accept more than just those two OperationApplyTime parameters
…ed, task status The FirmwareTaskStatus method is to replace FirmwareInstallStatus
There has been no real use for having an io.Reader passed in and this interface is to expect a file instead.
… x11, x12 based on feedback recieved this approach made more sense
Older X11 BMC firmwares don't include CSRF tokens in requests to the BMC API.
joelrebel
force-pushed
the
redfishwrapper-changes
branch
from
e37fd77 to
e6f756a
Compare
|
rebase on main |
DoctorVin
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
Note: to be merged after #362
redfishwrapperfor querying Redfish Task, Odata IDsThe firmware methods from the redfish provider will be moved into vendor specific providers,
which will call into the
redfishwrapperwhere required.Since each vendor requires its own set of OEM parameters and theres differences in the way the Tasks are handled, the current redfish firmware install methods are getting cumbersome to maintain and extend.
Checklist