Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eof): dont run precompile on ext delegate call #1964

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

rakita
Copy link
Member

@rakita rakita commented Jan 3, 2025

Part of this commit: 346aa01 - Osaka Activation (release_49 branch) (#1835) (6 weeks ago)

Ref to #1896

Copy link

codspeed-hq bot commented Jan 3, 2025

CodSpeed Performance Report

Merging #1964 will degrade performances by 2.82%

Comparing rakita/fix_eof_delegate_osaka_panic (f36e0e6) with main (f6cf872)

Summary

❌ 1 regressions
✅ 7 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main rakita/fix_eof_delegate_osaka_panic Change
`precompile bench ecrecover precompile` 197.4 µs 203.1 µs

@rakita rakita merged commit 894bcfb into main Jan 3, 2025
27 checks passed
@rakita rakita mentioned this pull request Jan 3, 2025
@github-actions github-actions bot mentioned this pull request Jan 3, 2025
@rakita rakita deleted the rakita/fix_eof_delegate_osaka_panic branch January 3, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant