Skip to content

Commit

Permalink
feat: upgrade to node v20 (#527)
Browse files Browse the repository at this point in the history
  • Loading branch information
martines3000 authored Dec 1, 2023
1 parent 9504781 commit e3600c1
Show file tree
Hide file tree
Showing 10 changed files with 28 additions and 30 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
secrets:
NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
with:
pnpm-version: 8.9.2
node-version: 18.18.2
pnpm-version: 8.11.0
node-version: 20.10.0
number-of-agents: 4
main-branch-name: 'develop'
init-commands: |
Expand All @@ -34,5 +34,5 @@ jobs:
NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
with:
number-of-agents: 4
pnpm-version: 8.9.2
node-version: 18.18.2
pnpm-version: 8.11.0
node-version: 20.10.0
8 changes: 4 additions & 4 deletions .github/workflows/cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ jobs:
secrets:
NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
with:
pnpm-version: 8.9.2
node-version: 18.18.2
pnpm-version: 8.11.0
node-version: 20.10.0
number-of-agents: 2
main-branch-name: 'develop'
parallel-commands-on-agents: |
Expand All @@ -26,5 +26,5 @@ jobs:
NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
with:
number-of-agents: 2
pnpm-version: 8.9.2
node-version: 18.18.2
pnpm-version: 8.11.0
node-version: 20.10.0
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: 8.9.2
version: 8.11.0

- name: Install node
uses: actions/setup-node@v3
with:
node-version: 18.18.2
node-version: 20.10.0
registry-url: https://registry.npmjs.org/
cache: 'pnpm'

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-beta.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: 8.9.2
version: 8.11.0

- name: Install node
uses: actions/setup-node@v3
with:
node-version: 18.18.2
node-version: 20.10.0
registry-url: https://registry.npmjs.org/
cache: 'pnpm'

Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/sonarcloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: 8.9.2
version: 8.11.0
- uses: actions/setup-node@v3
with:
node-version: 18.18.2
node-version: 20.10.0
cache: pnpm
- name: Install dependencies
run: pnpm install --frozen-lockfile
Expand Down Expand Up @@ -58,10 +58,10 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: 8.9.2
version: 8.11.0
- uses: actions/setup-node@v3
with:
node-version: 18.18.2
node-version: 20.10.0
cache: pnpm
- name: Install dependencies
run: pnpm install --frozen-lockfile
Expand Down Expand Up @@ -147,10 +147,10 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: 8.9.2
version: 8.11.0
- uses: actions/setup-node@v3
with:
node-version: 18.18.2
node-version: 20.10.0
cache: pnpm
- name: Install dependencies
run: pnpm install --frozen-lockfile
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: 8.9.2
version: 8.11.0

- name: Install node
uses: actions/setup-node@v3
with:
node-version: 18.18.2
node-version: 20.10.0
registry-url: https://registry.npmjs.org/
cache: 'pnpm'

Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.18.2
v20.10.0
6 changes: 2 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
FROM node:18.18.2-alpine3.16
FROM node:20.10.0-alpine3.18

WORKDIR /app

# Install pnpm
RUN npm i -g pnpm@8.9.2
RUN npm i -g pnpm@8.11.0

# Copy patches
COPY ./patches ./patches
Expand Down Expand Up @@ -37,8 +37,6 @@ COPY . .
# that depend on some of the files copied above
RUN pnpm install --frozen-lockfile

# Copy nx-cloud.env
COPY ./nx-cloud.env ./
ENV NODE_ENV=production

# For Dapp to build as Standalone
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,13 @@
"ts-node": "^10.9.1",
"typescript": "^5.2.2"
},
"packageManager": "pnpm@8.9.2",
"packageManager": "pnpm@8.11.0",
"engines": {
"node": ">=18.18.2"
"node": ">=20.10.0"
},
"volta": {
"node": "18.18.2",
"pnpm": "8.9.2"
"node": "20.10.0",
"pnpm": "8.11.0"
},
"pnpm": {
"patchedDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/dapp/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM blockchain-lab-um/masca:latest as builder

FROM node:18.18.2-alpine3.16
FROM node:20.10.0-alpine3.18

# Create app directory
RUN mkdir -p /app
Expand Down

0 comments on commit e3600c1

Please sign in to comment.