Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Wallet Wizard #239

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Conversation

SuperJMN
Copy link
Contributor

@SuperJMN SuperJMN commented Jan 7, 2025

This adds the actual wizard

@SuperJMN SuperJMN marked this pull request as draft January 8, 2025 12:24
@SuperJMN SuperJMN marked this pull request as ready for review January 8, 2025 23:44
sondreb
sondreb previously approved these changes Jan 9, 2025
Copy link
Member

@sondreb sondreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code without running it yet, thanks for this PR.

  • One future comment is to avoid using spaces ("_") in source code. Instead of calling it step "Step_3", it should be "Step3".

using ReactiveUI.SourceGenerators;
using ReactiveUI.Validation.Helpers;

namespace AngorApp.Sections.Wallet.Create.Step_2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested we never really _ for types or ns only maybe for params, rename this to Step2

@SuperJMN
Copy link
Contributor Author

SuperJMN commented Jan 9, 2025

Reviewed the code without running it yet, thanks for this PR.

  • One future comment is to avoid using spaces ("_") in source code. Instead of calling it step "Step_3", it should be "Step3".

Thanks! I've replaced conflicting namespaces already.

@dangershony dangershony merged commit 9962b12 into block-core:main Jan 9, 2025
3 checks passed
@SuperJMN SuperJMN deleted the new-wallet-wizard branch January 10, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants