-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Wallet Wizard #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code without running it yet, thanks for this PR.
- One future comment is to avoid using spaces ("_") in source code. Instead of calling it step "Step_3", it should be "Step3".
using ReactiveUI.SourceGenerators; | ||
using ReactiveUI.Validation.Helpers; | ||
|
||
namespace AngorApp.Sections.Wallet.Create.Step_2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As suggested we never really _
for types or ns only maybe for params, rename this to Step2
Thanks! I've replaced conflicting namespaces already. |
This adds the actual wizard