fix afterChange may override other extensions (#15)

blib-la · Feb 25, 2024 · a07b2fd · a07b2fd
1 parent e1b1729
commit a07b2fd
Showing 1 changed file with 23 additions and 27 deletions.
diff --git a/extensions/colors.js b/extensions/colors.js
@@ -184,45 +184,40 @@ function colorPositiveNegative(app) {
  * Colors
  */
 let afterChange;
+let colorModeValue;
+function invokeAfterChange() {
+  switch (colorModeValue) {
+    case 1:
+      uncolor(app);
+      break;
+    case 2:
+      rainbowify(app);
+      break;
+    case 3:
+      colorByType(app);
+      break;
+    default:
+      break;
+  }
+  if (getPosNegValue()) {
+    colorPositiveNegative(app);
+  }
+  return afterChange?.apply(this, arguments);
+}
+
 function setColorMode(value, app) {
+  colorModeValue = value;
   switch (value) {
     case 1:
-      app.graph.afterChange = function () {
-        uncolor(app);
-        if (getPosNegValue()) {
-          colorPositiveNegative(app);
-        }
-        return afterChange?.apply(this, arguments);
-      };
       uncolor(app);
       break;
     case 2:
-      app.graph.afterChange = function () {
-        rainbowify(app);
-        if (getPosNegValue()) {
-          colorPositiveNegative(app);
-        }
-        return afterChange?.apply(this, arguments);
-      };
       rainbowify(app);
       break;
     case 3:
-      app.graph.afterChange = function () {
-        colorByType(app);
-        if (getPosNegValue()) {
-          colorPositiveNegative(app);
-        }
-        return afterChange?.apply(this, arguments);
-      };
       colorByType(app);
       break;
     default:
-      app.graph.afterChange = function () {
-        if (getPosNegValue()) {
-          colorPositiveNegative(app);
-        }
-        return afterChange?.apply(this, arguments);
-      };
       app.graph._nodes.forEach((node) => {
         node.bgcolor = node._bgcolor ?? node.bgcolor;
         node.color = node._color ?? node.color;
@@ -275,6 +270,7 @@ app.registerExtension({
   },
   async init(app) {
     afterChange = app.graph.afterChange;
+    app.graph.afterChange = invokeAfterChange;
     const onMenuNodeColors = LGraphCanvas.onMenuNodeColors;
     LGraphCanvas.onMenuNodeColors = function (value, options, e, menu, node) {
       const response = onMenuNodeColors.apply(this, arguments);