FSDP-QLoRA doc updates for TRL integration #1471
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small documentation changes to maintain compatibility as the
SFTTrainer
class received updates as of TRL v0.13.0:max_seq_length
anddataset_text_field
moved to becomeSFTConfig
class arguments from theSFTTrainer
, causing errors when calling the trainer if these arguments are retained.tokenizer
argument is being deprecated in favor of the more generalprocessing_class
, which can be a tokenizer.The doc currently does not define the
training_arguments
arg, but we can assume that this is a an instance of theSFTConfig
class in which casemax_seq_length
anddataset_text_field
would be defined there. I have removed these args from theSFTTrainer
instantiation because of this, although these arguments could be defined in a config if that is preferable.Swapping the
tokenizer
forprocessing_class
deals with the second change. This modification is optional as thetokenizer
kwarg is deprecated and swapped automatically, but will probably be useful going forward.