Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust plural forms for translations #716

Closed
wants to merge 2 commits into from

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Mar 1, 2023

These plural forms were re-added in #557.

The following make -C src translate also caught a new last-minute added string.

hebasto added 2 commits March 1, 2023 15:58
The diff is produced by running `make -C src translate`.
@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 1, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #724 (Update translation source file for v25.0 string freeze by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@hebasto
Copy link
Member Author

hebasto commented Mar 1, 2023

cc @jarolrod @luke-jr

@jarolrod
Copy link
Member

concept ack

hebasto added a commit that referenced this pull request Apr 1, 2023
e414edd qt: Update translation source file (Hennadii Stepanov)
b780095 qt: Adjust plural forms for translations (Hennadii Stepanov)
6ae8a24 GUI: Send: Make feerates translatable (Luke Dashjr)
bd42f5e Bugfix: GUI: Send/PSBT: Correct virtual size unit and make translatable (Luke Dashjr)
1b0407f Bugfix: GUI: transactiondesc: Translate outlier "own address" and "watch-only" (Luke Dashjr)
170f312 GUI: Use translated external signer errors for messagebox text (Luke Dashjr)
9698959 GUI: Make messages for copying unsigned PSBTs translatable (Luke Dashjr)
08b8b28 Bugfix: GUI: Debug info: Use correct "kB" case for small mempool sizes, and make translation-friendly (Luke Dashjr)
dacc322 GUI: PSBTOperationsDialog: Support translating window title (Luke Dashjr)
5a4fe55 GUI: Intro: Support translating caption of data directory chooser (Luke Dashjr)
3868ba3 GUI: Support translating peer network names (Luke Dashjr)
f1f9811 GUI: Support translating address type dropdown entries (Luke Dashjr)

Pull request description:

  This PR updates the `src/qt/locale/bitcoin_en.xlf` translation source file according to [Release schedule for 25.0](bitcoin/bitcoin#26549).

  Some translation-related fixes have been picked from #599 and #716.

  Note for reviewers: it is expected to get a zero diff after running `make -C src translate` locally.

ACKs for top commit:
  jarolrod:
    ACK e414edd

Tree-SHA512: 5b0c70db1e2f5871067e84f43ebea4ee4f0027fc5f2be49bbcb1d04e162ae76607b2b038e9d0622bcb5b3658d0ede8c10c4421ddaa3343f0e0be54315ca7a4f5
@hebasto
Copy link
Member Author

hebasto commented Apr 1, 2023

Closed in favour of #724.

@hebasto hebasto closed this Apr 1, 2023
@hebasto hebasto deleted the 230301-plurals branch April 13, 2023 10:44
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants