Finalize implementation of keepkey and add automated tests for it #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to a bug in the KeepKey python library, this currently cannot be merged as when the library is installed, pieces are missing. This will also cause it to fail travis for now. |
achow101
force-pushed
the
keepkey-test
branch
11 times, most recently
from
55a31d7 to
76bbe79
Compare
|
is this WIP? |
Kind of. It's waiting on upstream changes. However I have finished everything else. |
achow101
force-pushed
the
keepkey-test
branch
from
76bbe79 to
c43de9a
Compare
achow101
changed the title
|
Upstream has fixed their issues (besides their versioning and PyPi problems) so this is ready for review now. Instead of splitting implementation and tests, I have decided to just make them one large pr as having tests make it easier to check that the implementation is correct. Also rebased. |
|
I filed a few issues for things on our end that could be better: |
achow101
force-pushed
the
keepkey-test
branch
from
c43de9a to
67e7508
Compare
All commands are implemented for the keepkey, so update the docs to reflect that
Allows enumerating the UDPTransport in order to connect to the Keepkey emulator. Because the keepkey and trezor emulators use the same interface, some conditions are used to avoid enumerating the emulator as the wrong type.
The trezor and keepkey emulators use the same port so they cannot be run at the same time. To work around this, the emulators are instead started and stopped before and after each test using unittest's setUp and tearDown functions. However, other devices which do not have conflicts can still be run at test suite creation time. This is still done for the coldcard. Furthermore, since the trezor and keepkey both create and use emulator.img files in the current working directory, when they are started, the working directory is changed to be the one containing the emulator executable to avoid conflicting emulator.img files
achow101
force-pushed
the
keepkey-test
branch
from
67e7508 to
8ddf434
Compare
|
utACK |
achow101
added a commit
that referenced
this pull request
Jan 14, 2019
…s for it 8ddf434 Refactor tests to optionally have emulator start and stop for each test (Andrew Chow) a3f31aa Add keepkey automated test (Andrew Chow) b7f5288 Use DebugLink for Keepkey UDPTransport (Andrew Chow) 8d53b7d Build keepkey emulator in setup_environment (Andrew Chow) 113bbe9 Enumerate the keepkey emulator (Andrew Chow) 50e72ad Update documentation for keepkey (Andrew Chow) 6857593 Implement multisig input signing and fixes to signtx for keepkey (Andrew Chow) 9d6949d Implement displayaddress for keepkey (Andrew Chow) 80873f9 Implement signmessage for keepkey (Andrew Chow) bf67fc6 Use keepkey 6.0.1 from keepkey/python-keepkey repo (Andrew Chow) Pull request description: Implements the signmessage, displayaddress, and signtx commands for the keepkey. This also completes its implementation and the documentation is updated as such. Note that because the Keepkey is a clone of the Trezor, these implementations are copies of the Trezor ones modified slightly to work with the Keepkey library. This also adds an automated test for the KeepKey using the KeepKey simulator. Tree-SHA512: 3e2491f4909df2a34e85dd7f051762cad8a12e948eb87709a6c943b9a62f2a208eb36966a80b50ffa2f976c49c775e944b796855f1caa00c1c812c2a8bf7b3c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the signmessage, displayaddress, and signtx commands for the keepkey. This also completes its implementation and the documentation is updated as such.
Note that because the Keepkey is a clone of the Trezor, these implementations are copies of the Trezor ones modified slightly to work with the Keepkey library.
This also adds an automated test for the KeepKey using the KeepKey simulator.