Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OSPFv3 packet layer #235

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Implement OSPFv3 packet layer #235

wants to merge 26 commits into from

Conversation

mraerino
Copy link
Contributor

Supports decoding and encoding of OSPFv3 messages in IPv6 packets.

RFC: 5340 - OSPF for IPv6

Test suite

Testing is based on packet captures from packetlife - in fixtures

Decoding

Decodes all packets from the capture. Only fails on unexpected conditions (length or checksum mismatch).

Encoding

Encodes go structs from snapshots in fixtures/packets. Compares the results to the packet capture.
To update the snapshots, run go run ./protocols/ospf/packetv3/fixtures/packets/gen/.

@mraerino mraerino force-pushed the packet/ospfv3 branch 2 times, most recently from 137a8a1 to 4129f73 Compare December 27, 2019 16:56
@codecov-io
Copy link

codecov-io commented Dec 27, 2019

Codecov Report

Merging #235 into master will decrease coverage by 0.11%.
The diff coverage is 57.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
- Coverage   59.16%   59.04%   -0.12%     
==========================================
  Files         137      141       +4     
  Lines        7412     8012     +600     
==========================================
+ Hits         4385     4731     +346     
- Misses       2848     3075     +227     
- Partials      179      206      +27
Impacted Files Coverage Δ
protocols/ospf/packetv3/lsa.go 45.62% <45.62%> (ø)
protocols/ospf/packetv3/lsa_prefix.go 50% <50%> (ø)
protocols/ospf/packetv3/common.go 60.71% <60.71%> (ø)
protocols/ospf/packetv3/packet.go 77.66% <77.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f280f19...a6a2efc. Read the comment docs.

@mraerino mraerino force-pushed the packet/ospfv3 branch 2 times, most recently from 3f46ce5 to dec2506 Compare January 5, 2020 10:23
@codecov-commenter
Copy link

Codecov Report

Merging #235 into master will decrease coverage by 0.09%.
The diff coverage is 57.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
- Coverage   59.02%   58.92%   -0.10%     
==========================================
  Files         137      141       +4     
  Lines        7571     8171     +600     
==========================================
+ Hits         4469     4815     +346     
- Misses       2921     3148     +227     
- Partials      181      208      +27     
Impacted Files Coverage Δ
protocols/ospf/packetv3/lsa.go 45.62% <45.62%> (ø)
protocols/ospf/packetv3/lsa_prefix.go 50.00% <50.00%> (ø)
protocols/ospf/packetv3/common.go 60.71% <60.71%> (ø)
protocols/ospf/packetv3/packet.go 77.66% <77.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c05983...f08fc96. Read the comment docs.

@lwj5 lwj5 mentioned this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants