Game Genie support #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool, thank you! Do you think it'd be possible to get a test for this? That'd also double as a code example, as I see you've added and then removed. :) |
|
Adding a real test is a good idea (maybe a code for the included Concentration Room rom), will see what I can do |
bfirsh
reviewed
Nov 28, 2017
src/gg.js
Outdated
| @@ -0,0 +1,124 @@ | |||
|
|
|||
| var GG = function(nes) { | |||
| this.nes = nes; | |||
There was a problem hiding this comment.
this.nes is unused, I think, so can be removed.
|
👍 it looks like the gamegenie class can be easily unit tested, which would probably be sufficient. An integration test on a ROM would be great too, as you suggest. Thank you! |
bfirsh
requested changes
Nov 28, 2017
src/gg.js
Outdated
| @@ -0,0 +1,124 @@ | |||
|
|
|||
| var GG = function(nes) { | |||
There was a problem hiding this comment.
No need to abbreviate - GameGenie is much clearer.
src/nes.js
Outdated
| @@ -34,6 +35,7 @@ var NES = function(opts) { | |||
| this.cpu = new CPU(this); | |||
| this.ppu = new PPU(this); | |||
| this.papu = new PAPU(this); | |||
| this.gg = new GG(this); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for NES Game Genie codes (ROM patches)