-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: secure API using Cloudflare's Turnstile #158
base: staging
Are you sure you want to change the base?
Conversation
@bdebon: I pushed this yesterday evening but didn't take time to explain the feature and how to set it up 🥱 That's all very simple but let me do it before considering merging 😉 |
I read the pr, superb refactorings here and there and implementation of this turnstile thing that I have to confess I don't understand 100% for now (I have never used cloudflare so I'm missing some things here). Waiting for your explanation when you have time but super hyped about the content of this PR! Thank you so much! |
Here's my proper MR message ⚡ Why?We need a way to prevent spam 💀 How?Use Cloudflare's Turnstile feature (pretty much like reCAPTCHA). What steps do we need?On page load:
When submitting a choice:
What's required?We need to set up a Turnstile site (any Cloudflare account can do this). This will give us a I created a "localhost" pair and stored the @bdebon: I can share the secret key privately, or I can let you create a Turnstile config yourself and use your own values (that's what I'd recommend). What could be improved?
Thanks 🙏 |
Just found an issue with my token validation test. Will fix ASAP. |
All good now 😉 |
Hey @quentint, you still have a problem during the build, you can check the ci log for more detail. I'm gonna read the rest of your explanation ! |
Perfect explanations thank you so much! I will create a cloudflare account for the sake of seeing how all of this work. I think I understand everything about this PR and I could be able to merge and finish the implementation. |
Yup, I saw that error. Will try to find a better way to store this. |
Fighting h@ckers with Cloudflare's Turnstile 😉
See #100 for details and discussion.