Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to PrimeVue 4.0 #234

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft

Migrate to PrimeVue 4.0 #234

wants to merge 30 commits into from

Conversation

kyle1morel
Copy link
Collaborator

@kyle1morel kyle1morel commented Jan 7, 2025

Description

Update from PrimeVue 3.x to 4.x
Migrate from PrimeFlex to TailwindCSS + PrimeUI Plugin
Create custom PrimeVue theme

Fill in more later maybe

Types of changes

Bug fix (non-breaking change which fixes an issue)

Documentation (non-breaking change with enhancements to documentation)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

wilwong89 and others added 28 commits January 7, 2025 11:59
Replacing depreciated component Dropdown with Select

Updated renamed components, inputswitch to toggleswitch, sidebar to drawer

Update Stepper component to new version

Update Accordion component to new format, fix submission intake navigation, fix map resize

Replace depreciated TabView component with Tabs

Primevue theming/CSS changes, handle input component blur events

WIP updating color vars
Replaces PrimeFlex which is incompatible with PrimeVue 4.0
Copy link

github-actions bot commented Jan 7, 2025

Coverage Report (Application)

Totals Coverage
Statements: 37.06% ( 1061 / 2863 )
Methods: 26.28% ( 128 / 487 )
Lines: 48.44% ( 699 / 1443 )
Branches: 25.08% ( 234 / 933 )

Copy link

github-actions bot commented Jan 7, 2025

Coverage Report (Frontend)

Totals Coverage
Statements: 46.27% ( 3240 / 7002 )
Methods: 34.9% ( 416 / 1192 )
Lines: 54.08% ( 1867 / 3452 )
Branches: 40.59% ( 957 / 2358 )

Copy link

github-actions bot commented Jan 7, 2025

@naixin-zhangbc
Copy link

We are putting together a Figma file with screenshots and styling markups for all the needed changes. In the meantime, here are a couple bugs we noticed:

  • Drafts are not deleting after submission. If auto-save saved some drafts, after submission it should get rid of the drafts.
  • Once the button for activating a tooltip has been clicked, the tooltip message sticks on the screen across all pages. This happens to all tooltips.

@naixin-zhangbc
Copy link

Here are all the needed changes besides the bugs mentioned above. https://www.figma.com/design/udtqyDmqaYte03ANaS10S2/PAT?node-id=5716-457

Also removed formgrid across app. it doesnt exist anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants