-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to PrimeVue 4.0 #234
Draft
kyle1morel
wants to merge
30
commits into
master
Choose a base branch
from
feature/primevue-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation, fix map resize
Replacing depreciated component Dropdown with Select Updated renamed components, inputswitch to toggleswitch, sidebar to drawer Update Stepper component to new version Update Accordion component to new format, fix submission intake navigation, fix map resize Replace depreciated TabView component with Tabs Primevue theming/CSS changes, handle input component blur events WIP updating color vars
Replaces PrimeFlex which is incompatible with PrimeVue 4.0
Release dcdbb91 deployed at https://pcns-dev-pr-234.apps.silver.devops.gov.bc.ca |
We are putting together a Figma file with screenshots and styling markups for all the needed changes. In the meantime, here are a couple bugs we noticed:
|
Here are all the needed changes besides the bugs mentioned above. https://www.figma.com/design/udtqyDmqaYte03ANaS10S2/PAT?node-id=5716-457 |
Also removed formgrid across app. it doesnt exist anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update from PrimeVue 3.x to 4.x
Migrate from PrimeFlex to TailwindCSS + PrimeUI Plugin
Create custom PrimeVue theme
Fill in more later maybe
Types of changes
Bug fix (non-breaking change which fixes an issue)
Documentation (non-breaking change with enhancements to documentation)
Breaking change (fix or feature that would cause existing functionality to change)
Checklist
Further comments