windows launcher: Make the launcher compile under mingw #24752
Conversation
github-actions
bot
added
the
awaiting-review
| # TODO(#8303): Mac crosstool should also declare every feature. | ||
| if is_linux: | ||
| # Linux artifact name patterns are the default. | ||
| artifact_name_patterns = [ |
There was a problem hiding this comment.
This is forked from rules_cc with only diff being adding .exe extension for binaries.
|
@fmeum @meteorcloudy sorry for not properly testing my last PR #24725. I only check https://godbolt.org/z/f35j3M4x9 compile but |
| int wmain(int argc, wchar_t* argv[]) { | ||
| #else | ||
| int main() { |
There was a problem hiding this comment.
mingw requires linkopt -municode to use wmain.
There was a problem hiding this comment.
Can you add this comment in the code?
There was a problem hiding this comment.
I will do it later. I am on a train currently.
There was a problem hiding this comment.
Comments added. PTAL.
| @@ -250,7 +250,7 @@ wstring JavaBinaryLauncher::CreateClasspathJar(const wstring& classpath) { | |||
| binary_base_path + rand_id + L".jar_manifest"; | |||
| blaze_util::AddUncPrefixMaybe(&jar_manifest_file_path); | |||
| #if (__cplusplus >= 201703L) | |||
| wofstream jar_manifest_file(std::filesystem::path(jar_manifest_file_path)); | |||
| wofstream jar_manifest_file{std::filesystem::path(jar_manifest_file_path)}; | |||
There was a problem hiding this comment.
We need to use curly brackets here to declare a variable.
BoleynSu
changed the title
BoleynSu
force-pushed
the
patch-4
branch
2 times, most recently
from
e4d7f2f to
f0401ef
Compare
sgowroji
added
the
team-OSS
I'm fine with tweaking the launcher code to allow it build with mingw, but it's not ideal to check in more toolchain config files in Bazel code base. Can you put it your own repo and reference it as needed? |
BoleynSu
force-pushed
the
patch-4
branch
2 times, most recently
from
bf26bcc to
d660e51
Compare
|
Removed the changes to add a mingw cc toolchain |
|
@bazel-io fork 8.0.1 |
|
@bazel-io fork 7.5.0 |
|
@bazel-io fork 8.1.0 |
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
TEST: bazel build --platforms=//:windows_x86_64 --extra_toolchains=@llvm_mingw_linux_x86_64//:cc-toolchain-linux_x86_64-windows_x86_64 //src/tools/launcher:launcher Closes bazelbuild#24752. PiperOrigin-RevId: 711358608 Change-Id: Iedacad9b959427ed5d4598e0ea594cb25b8845c8
TEST: bazel build --platforms=//:windows_x86_64 --extra_toolchains=@llvm_mingw_linux_x86_64//:cc-toolchain-linux_x86_64-windows_x86_64 //src/tools/launcher:launcher Closes #24752. PiperOrigin-RevId: 711358608 Change-Id: Iedacad9b959427ed5d4598e0ea594cb25b8845c8 Commit a4bb254 Co-authored-by: Boleyn Su <boleyn.su@gmail.com>
TEST: bazel build --platforms=//:windows_x86_64 --extra_toolchains=@llvm_mingw_linux_x86_64//:cc-toolchain-linux_x86_64-windows_x86_64 //src/tools/launcher:launcher