fix: CMAKE_MODULE_LINKER_FLAGS_INIT breaks macos builds #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsun-splunk
force-pushed
the
jsun-cmake-module
branch
2 times, most recently
from
148e04b to
4b01d58
Compare
The PR bazel-contrib#1308, added `CMAKE_MODULE_LINKER_FLAGS_INIT` with the value of cxx_linker_shared to the generated toolchain file in CMAKE. This works for most use cases, however, it broke some macos builds that build bundles. This is because the toolchain usually sets "-shared" or "-dynamiclib" while CMAKE sets "-bundle" for Apple platforms. "-bundle" cannot co-exist with the previous two flags.
jsun-splunk
force-pushed
the
jsun-cmake-module
branch
from
4b01d58 to
70fe21b
Compare
jsharpe
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #1308, added
CMAKE_MODULE_LINKER_FLAGS_INITwith the value of cxx_linker_shared to the generated toolchain file in CMAKE.This works for most use cases, however, it broke some macos builds that build bundles. This is because the toolchain usually sets "-shared" or "-dynamiclib" while CMAKE sets "-bundle" for Apple platforms. "-bundle" cannot co-exist with the previous two flags.