Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in annotations with MSSQL and PostgreSQL databases #61

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

hasathcharu
Copy link
Contributor

@hasathcharu hasathcharu commented Mar 20, 2024

Purpose

Adds advanced compiler validation for @sql:Relation annotation, fix an issue with @sql:Name annotation when running join queries and adds support for MSSQL and PostgreSQL databases for @sql:Generated annotation.

Fixes:

  • #6188
  • Fixed an issue where the columnNames are mapped incorrectly in join queries when using the @sql:Name annotation
  • Improved support for @sql:Generated annotations for MSSQL and PostgreSQL databases

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 85.31%. Comparing base (4b8c6cc) to head (2baa56b).

Files Patch % Lines
.../persist/sql/compiler/pluginutils/PluginUtils.java 29.41% 0 Missing and 12 partials ⚠️
...l/compiler/PersistSqlModelDefinitionValidator.java 94.02% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #61      +/-   ##
============================================
+ Coverage     84.73%   85.31%   +0.58%     
- Complexity      264      277      +13     
============================================
  Files            23       23              
  Lines          1677     1730      +53     
  Branches        466      476      +10     
============================================
+ Hits           1421     1476      +55     
  Misses          156      156              
+ Partials        100       98       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants