Add Github workflow to the Redis DB bal persist client #3
Conversation
dinukaamarasinghe817
changed the title
dinukaamarasinghe817
force-pushed
the
github-workflow
branch
3 times, most recently
from
81dafee to
0c1801b
Compare
dinukaamarasinghe817
force-pushed
the
github-workflow
branch
from
0c1801b to
6cedb60
Compare
build.gradle
Outdated
| id "com.github.spotbugs" version "${githubSpotbugsVersion}" | ||
| id "com.github.johnrengelman.shadow" version "${githubJohnrengelmanShadowVersion}" | ||
| id "de.undercouch.download" version "${underCouchDownloadVersion}" | ||
| id "net.researchgate.release" version "${researchgateReleaseVersion}" |
There was a problem hiding this comment.
Shall we move the plugin management to the settings.gradle file? Check this out:
Notice that the plugin versions are handled in the settings.gradle file while the build.gradle files are just using those plugins, not handling the versions.
build.gradle
Outdated
|
|
||
| def packageName = "persist.redis" | ||
|
|
||
| ext.ballerinaLangVersion = project.ballerinaLangVersion |
There was a problem hiding this comment.
We don't need this ext definition.
gradle.properties
Outdated
| # Transitive Dependencies | ||
| # Level 01 | ||
| stdlibConstraintVersion=1.4.0 | ||
|
|
||
| #Level 02 | ||
| stdlibCryptoVersion=2.5.0 | ||
| stdlibTaskVersion=2.5.0 | ||
|
|
||
| # Level 03 | ||
| stdlibCacheVersion=3.7.0 | ||
| stdlibMimeVersion=2.9.0 | ||
| stdlibUuidVersion=1.7.0 | ||
|
|
||
| # Level 04 | ||
| stdlibAuthVersion=2.10.0 | ||
| stdlibJwtVersion=2.10.0 | ||
| stdlibOAuth2Version=2.10.0 |
There was a problem hiding this comment.
When it comes to dependency management in the gradle.properties, it doesn't make much sense to differentiate the direct and transitive dependencies. IMO, it is better to just put them together by grouping them using the level.
gradle/libs.versions.toml
Outdated
| @@ -0,0 +1,7 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip | |||
There was a problem hiding this comment.
Let's use Gradle 8.2.1 version. Note that changing the version will require you to update the wrapper jar as well.
There was a problem hiding this comment.
All the suggestions have been addressed in 500fc9b
dinukaamarasinghe817
force-pushed
the
github-workflow
branch
4 times, most recently
from
f4e04ec to
c7c12f4
Compare
dinukaamarasinghe817
force-pushed
the
github-workflow
branch
from
c7c12f4 to
500fc9b
Compare
There was a problem hiding this comment.
Let's use the centralized workflow templates for these workflows.
Purpose