Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Project with Generated Client, Update package.md, Test and Validate Functionality #3

Open
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

Irash-Perera
Copy link

@Irash-Perera Irash-Perera commented Dec 22, 2024

Purpose

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2024

CLA assistant check
All committers have signed the CLA.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/feedback_review/Ballerina.toml Outdated Show resolved Hide resolved
examples/feedback_review/main.bal Outdated Show resolved Hide resolved
examples/feedback_review/main.bal Outdated Show resolved Hide resolved
examples/feedback_review/main.bal Outdated Show resolved Hide resolved
examples/feedback_review/main.bal Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
Comment on lines 36 to 38
### Step 2 (Optional): Create a [Developer Test Account](https://developers.hubspot.com/beta-docs/getting-started/account-types#developer-test-accounts) under your account

Within app developer accounts, you can create developer test accounts to test apps and integrations without affecting any real HubSpot data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Step 2 (Optional): Create a [Developer Test Account](https://developers.hubspot.com/beta-docs/getting-started/account-types#developer-test-accounts) under your account
Within app developer accounts, you can create developer test accounts to test apps and integrations without affecting any real HubSpot data.
### Step 2 (Optional): Create a Developer Test Account
Within app developer accounts, you can create a [developer test account](https://developers.hubspot.com/beta-docs/getting-started/account-types#developer-test-accounts) under your account to test apps and integrations without affecting any real HubSpot data.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check all the comments that are marked as resolved, without being fixed.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
build-config/resources/Ballerina.toml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated
Comment on lines 189 to 192
1. Read a page of feedback submissions.
2. Read an Object identified by `{feedbackSubmissionId}`
3. Read a batch of feedback submissions by internal ID, or unique property values
4. Search feedback submissions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the comment is resolved, the links are not added. Please check again.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused to link one ballerina project with 4 use cases. I fixed it. Hope now it is okay

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ballerina/tests/test.bal Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
Comment on lines 189 to 192
1. Read a page of feedback submissions.
2. Read an Object identified by `{feedbackSubmissionId}`
3. Read a batch of feedback submissions by internal ID, or unique property values
4. Search feedback submissions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the comment is resolved, the links are not added. Please check again.

ballerina/Module.md Outdated Show resolved Hide resolved
ballerina/Module.md Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved

[build-options]
observabilityIncluded = true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

examples/feedback_review/main.bal Outdated Show resolved Hide resolved
examples/feedback_review/main.bal Outdated Show resolved Hide resolved
examples/feedback_review/main.bal Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ballerina/Module.md Outdated Show resolved Hide resolved
ballerina/Module.md Outdated Show resolved Hide resolved
ballerina/Package.md Show resolved Hide resolved
ballerina/tests/mock_test.bal Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
examples/feedback_review/main.bal Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ballerina/Module.md Outdated Show resolved Hide resolved
ballerina/Package.md Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants