Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.9.x] Add support for configuring server name to be used in the SSL SNI extension #2242

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

TharmiganK
Copy link
Contributor

Purpose

Add support for configuring the server name to be used in the SSL SNI extension.
Related issue: ballerina-platform/ballerina-library#7435

Introduced a new field named serverName in the secureSocket config under ClientConfiguration.

Examples

http:ClientConfiguration clientConf = {
    secureSocket: {
        cert: {
            path: common:TRUSTSTORE_PATH,
            password: "ballerina"
        },
        serverName: "localhost"
    }
};

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • Checked the impact on OpenAPI generation

Copy link

sonarqubecloud bot commented Dec 5, 2024

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (b57690d) to head (de5a8ba).
Report is 6 commits behind head on 2201.9.x.

Additional details and impacted files
@@              Coverage Diff               @@
##             2201.9.x    #2242      +/-   ##
==============================================
- Coverage       80.96%   80.89%   -0.08%     
  Complexity        561      561              
==============================================
  Files             391      391              
  Lines           21647    21659      +12     
  Branches         4994     4996       +2     
==============================================
- Hits            17527    17520       -7     
- Misses           3105     3125      +20     
+ Partials         1015     1014       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TharmiganK TharmiganK merged commit ca430bb into 2201.9.x Dec 6, 2024
8 checks passed
@TharmiganK TharmiganK deleted the bug-fixes-2201.9.x branch December 6, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants