-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2201.5.x] Add support for configuring server name to be used in the SSL SNI extension #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bhashinee
commented
Dec 4, 2024
ayeshLK
reviewed
Dec 4, 2024
native/src/main/java/io/ballerina/stdlib/http/api/HttpUtil.java
Outdated
Show resolved
Hide resolved
Bhashinee
commented
Dec 5, 2024
Quality Gate passedIssues Measures |
TharmiganK
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add support for configuring the server name to be used in the SSL SNI extension.
Related issue: ballerina-platform/ballerina-library#7435
Introduced a new field named
serverName
in thesecureSocket
config underClientConfiguration
.Examples
@shafreenAnfar @TharmiganK I used
serverName
as the field name as it is the name that has been used in the Go language as well. If you have any concerns with the name, please suggest.Checklist