[Master] Add support for configuring server name to be used in the SSL SNI extension #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bhashinee
requested review from
daneshk,
TharmiganK,
lnash94 and
shafreenAnfar
as code owners
TharmiganK
reviewed
Dec 4, 2024
ballerina-tests/http-security-tests/tests/ssl_sni_host_name_test.bal
Outdated
Show resolved
Hide resolved
ballerina-tests/http-security-tests/tests/ssl_sni_host_name_test.bal
Outdated
Show resolved
Hide resolved
ballerina-tests/http-security-tests/tests/ssl_sni_host_name_test.bal
Outdated
Show resolved
Hide resolved
ballerina-tests/http-security-tests/tests/ssl_sni_host_name_test.bal
Outdated
Show resolved
Hide resolved
ballerina-tests/http-security-tests/tests/ssl_sni_host_name_test.bal
Outdated
Show resolved
Hide resolved
| http:ClientConfiguration http1SniClientConf = { | ||
| httpVersion: http:HTTP_1_1, | ||
| secureSocket: { | ||
| cert: { |
There was a problem hiding this comment.
Shall we have a test without the cert i.e. with JVM default certs?
There was a problem hiding this comment.
We cannot configure only the serverName in the secureSocket config. It gives a runtime error.
Need to configure cert with client SSL certificates file
I think this is a bug. :D
There was a problem hiding this comment.
I think that is the usecase for the internal issue. I think we need to fix it as well. Lets address that in a separate issue
There was a problem hiding this comment.
Then I'll fix that as well.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add support for configuring the server name to be used in the SSL SNI extension.
Related issue: ballerina-platform/ballerina-library#7435
Examples
Checklist