Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP service contract type support #2037

Merged
merged 61 commits into from
Aug 3, 2024
Merged

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Jun 12, 2024

Purpose

$Subject

Part of:

Fixes: ballerina-platform/ballerina-library#6511

Examples

Checklist

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 67.26115% with 257 lines in your changes missing coverage. Please review.

Project coverage is 80.24%. Comparing base (b0932a9) to head (020bad2).
Report is 1 commits behind head on master.

Files Patch % Lines
...odemodifier/contract/ContractInfoModifierTask.java 32.07% 68 Missing and 4 partials ⚠️
...compiler/HttpServiceContractResourceValidator.java 61.79% 21 Missing and 13 partials ⚠️
...ina/stdlib/http/compiler/HttpServiceValidator.java 77.51% 11 Missing and 18 partials ⚠️
.../compiler/codeaction/ImplementServiceContract.java 59.09% 16 Missing and 11 partials ⚠️
...odifier/payload/PayloadAnnotationModifierTask.java 41.17% 16 Missing and 4 partials ⚠️
...a/stdlib/http/compiler/HttpCompilerPluginUtil.java 59.45% 6 Missing and 9 partials ⚠️
...demodifier/payload/HttpPayloadParamIdentifier.java 68.75% 9 Missing and 1 partial ⚠️
...java/io/ballerina/stdlib/http/api/HttpService.java 76.92% 4 Missing and 5 partials ⚠️
...lib/http/compiler/ResourceFunctionDeclaration.java 63.15% 7 Missing ⚠️
...dlib/http/compiler/HttpServiceObjTypeAnalyzer.java 72.72% 2 Missing and 4 partials ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2037      +/-   ##
============================================
- Coverage     80.71%   80.24%   -0.47%     
- Complexity      561      668     +107     
============================================
  Files           401      408       +7     
  Lines         22353    22914     +561     
  Branches       5166     5266     +100     
============================================
+ Hits          18042    18388     +346     
- Misses         3241     3395     +154     
- Partials       1070     1131      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TharmiganK TharmiganK force-pushed the service-type-support branch from b9d27b3 to 8edb5e8 Compare June 17, 2024 12:01
@TharmiganK TharmiganK force-pushed the service-type-support branch from 8edb5e8 to c57777a Compare June 17, 2024 12:10
@TharmiganK TharmiganK force-pushed the service-type-support branch from 3a4dfb8 to d08e922 Compare August 1, 2024 05:00
@TharmiganK TharmiganK force-pushed the service-type-support branch from 32155f0 to 8ec3ab1 Compare August 1, 2024 08:51
@TharmiganK TharmiganK marked this pull request as ready for review August 1, 2024 08:52
@TharmiganK TharmiganK force-pushed the service-type-support branch from 8ec3ab1 to 2db3f47 Compare August 1, 2024 08:58
lnash94
lnash94 previously approved these changes Aug 2, 2024
Copy link

sonarqubecloud bot commented Aug 3, 2024

@TharmiganK TharmiganK merged commit 5674c93 into master Aug 3, 2024
7 of 8 checks passed
@TharmiganK TharmiganK deleted the service-type-support branch August 3, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The OpenAPI introspection resource returns an incorrect specification
2 participants