Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for brotli compression format #2006

Closed
wants to merge 32 commits into from
Closed

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented May 17, 2024

Purpose

$Subject

Fixes: ballerina-platform/ballerina-library#6547

Examples

See the issue for more details

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • Checked the impact on OpenAPI generation

TharmiganK and others added 11 commits May 17, 2024 09:46
…oding-format

# Conflicts:
#	ballerina-tests/http-advanced-tests/Ballerina.toml
#	ballerina-tests/http-client-tests/Ballerina.toml
#	ballerina-tests/http-dispatching-tests/Ballerina.toml
#	ballerina-tests/http-interceptor-tests/Ballerina.toml
#	ballerina-tests/http-misc-tests/Ballerina.toml
#	ballerina-tests/http-resiliency-tests/Ballerina.toml
#	ballerina-tests/http-security-tests/Ballerina.toml
#	ballerina-tests/http-service-tests/Ballerina.toml
#	ballerina-tests/http2-tests/Ballerina.toml
#	ballerina/Ballerina.toml
#	ballerina/CompilerPlugin.toml
#	changelog.md
@github-actions github-actions bot added the Stale label Jul 2, 2024
@TharmiganK TharmiganK removed the Stale label Jul 3, 2024
@ballerina-platform ballerina-platform deleted a comment from github-actions bot Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 48.27586% with 15 lines in your changes missing coverage. Please review.

Project coverage is 80.17%. Comparing base (b222df2) to head (b2a5e9a).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
...nsport/contractimpl/Http2OutboundRespListener.java 43.75% 4 Missing and 5 partials ⚠️
...ner/http2/Http2SourceConnectionHandlerBuilder.java 57.14% 2 Missing and 1 partial ⚠️
...ttp/transport/message/HttpMessageDataStreamer.java 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2006      +/-   ##
============================================
- Coverage     80.42%   80.17%   -0.25%     
- Complexity        0      669     +669     
============================================
  Files           366      408      +42     
  Lines         20738    22985    +2247     
  Branches       4841     5284     +443     
============================================
+ Hits          16679    18429    +1750     
- Misses         3123     3414     +291     
- Partials        936     1142     +206     
Flag Coverage Δ
80.17% <48.27%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TharmiganK TharmiganK marked this pull request as ready for review August 21, 2024 09:21
@TharmiganK TharmiganK requested a review from lnash94 as a code owner August 23, 2024 03:41
@TharmiganK TharmiganK requested a review from daneshk as a code owner September 2, 2024 05:41
@TharmiganK
Copy link
Contributor Author

This PR is on hold, since this new feature should be added to Update 11

@NipunaRanasinghe
Copy link
Contributor

This PR is on hold, since this new feature should be added to Update 11

@TharmiganK if this is deprioratized, better to close it ftm and we can reopen once we resume the work IMO

@TharmiganK
Copy link
Contributor Author

@TharmiganK if this is deprioratized, better to close it ftm and we can reopen once we resume the work IMO

No, we will merge this for Update 11. I will make this draft since I need to do some testing.

@TharmiganK TharmiganK marked this pull request as draft September 13, 2024 08:26
Copy link

@TharmiganK
Copy link
Contributor Author

Closing this for now and will reopen after the testing

@TharmiganK TharmiganK closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HTTP compression support for brotli format
2 participants