Implement AccessLog support for Ballerina #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzeemMuzammil
requested review from
shafreenAnfar and
TharmiganK
as code owners
dilanSachi
reviewed
Apr 29, 2024
native/src/main/java/io/ballerina/stdlib/http/transport/message/HttpCarbonMessage.java
Show resolved
Hide resolved
dilanSachi
reviewed
Apr 29, 2024
...io/ballerina/stdlib/http/transport/contractimpl/sender/states/http2/ReceivingEntityBody.java
Outdated
Show resolved
Hide resolved
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
AzeemMuzammil
force-pushed
the
fb-access-log-improvement
branch
from
cf289ec to
a8d6a34
Compare
AzeemMuzammil
force-pushed
the
fb-access-log-improvement
branch
3 times, most recently
from
252ce36 to
a8d2f46
Compare
|
AzeemMuzammil
force-pushed
the
fb-access-log-improvement
branch
2 times, most recently
from
a115354 to
3dfd0e1
Compare
TharmiganK
reviewed
Jun 18, 2024
dilanSachi
reviewed
Jun 18, 2024
native/src/main/java/io/ballerina/stdlib/http/api/logging/accesslog/HttpAccessLogConfig.java
Show resolved
Hide resolved
dilanSachi
reviewed
Jun 18, 2024
native/src/main/java/io/ballerina/stdlib/http/api/logging/accesslog/HttpAccessLogConfig.java
Outdated
Show resolved
Hide resolved
dilanSachi
reviewed
Jun 19, 2024
.../java/io/ballerina/stdlib/http/transport/contractimpl/listener/states/SendingEntityBody.java
Outdated
Show resolved
Hide resolved
dilanSachi
reviewed
Jun 19, 2024
...io/ballerina/stdlib/http/transport/contractimpl/listener/states/http2/SendingEntityBody.java
Outdated
Show resolved
Hide resolved
dilanSachi
reviewed
Jun 19, 2024
.../java/io/ballerina/stdlib/http/transport/contractimpl/sender/states/ReceivingEntityBody.java
Outdated
Show resolved
Hide resolved
TharmiganK
reviewed
Jun 19, 2024
native/src/main/java/io/ballerina/stdlib/http/api/logging/HttpLogManager.java
Outdated
Show resolved
Hide resolved
TharmiganK
reviewed
Jun 19, 2024
TharmiganK
reviewed
Jun 19, 2024
AzeemMuzammil
force-pushed
the
fb-access-log-improvement
branch
from
c912f3e to
e0abe1a
Compare
AzeemMuzammil
force-pushed
the
fb-access-log-improvement
branch
from
375e0cd to
1794e52
Compare
AzeemMuzammil
dismissed stale reviews from dilanSachi and TharmiganK
via
70235e4
AzeemMuzammil
force-pushed
the
fb-access-log-improvement
branch
3 times, most recently
from
162fc72 to
74583fa
Compare
TharmiganK
previously approved these changes
Jul 11, 2024
AzeemMuzammil
force-pushed
the
fb-access-log-improvement
branch
from
4bc6011 to
a9092da
Compare
TharmiganK
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the proposal detailed in ballerina-platform/ballerina-library#6111. The implementation has been completed, and comprehensive load tests were conducted to evaluate the performance with and without the access log feature enabled.
The load tests were executed for 30 minutes to ensure stability and performance consistency. Different backends and testing tools were utilized for HTTP/1.1 and HTTP/2 passthrough scenarios:
HTTP/1.1 Passthrough Scenarios:
HTTP/2 Passthrough Scenarios:
These configurations were chosen to handle each protocol's specific requirements and challenges effectively. Additionally, we have added the load test results and memory usage metrics for the HTTP/2 passthrough scenarios, providing detailed insights into the performance and resource consumption under heavy load conditions.
Load Test Results:
h1-h1-pass-through scenario (Apache JMeter)
h1-h2-pass-through scenario (Apache JMeter)
h2-h2-pass-through scenario (h2load)
Result
Heap
CPU
Result
Heap
CPU
h2-h1-pass-through scenario (h2load)
Result
Heap
CPU
Result
Heap
CPU
Examples
Checklist