-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix - clean input after staking and updated title text #78
Conversation
jeremy-babylonlabs
commented
Aug 15, 2024
- Improved staking clear input logic
- updated staking and FP title text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremy-babylonlabs Do we need to count the resets as state?
@jeremy-babylonlabs wouldn't this be easier with way less changes? #80 But will need ur guys help on testing this tho. it works for me |
I don't understand why are we counting resets |
Because there are re-rending happening where the parent and child components (staking <-> stakingAmount) is affecting each other with their states and props being passed around. for example, Jeremy's solution is to a hack that try to fix another hack. It works, but u will see the counter actually incremented a lot (due to re-rendering issue in our code). I proposed another solution #80 which will at least cut the |
c93fa11
to
b5db28d
Compare
b5db28d
to
6a14b5d
Compare
using a reset counter can make sure the states rerenders in the lifecycle. but agreed and going with @jrwbabylonlab's approach for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremy-babylonlabs I suggest we do add strong
to steps, so it's more emphasized for the end user (for both steps)
<p>
<strong>Step-1:</strong> Select a finaltiy provider
</p>
Other than that PR does what it should - resets the amount