-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Playwright e2e #77
Conversation
81379c8
to
0707a72
Compare
0707a72
to
f361475
Compare
@gbarkhatov nice work! Feel more confident with future changes now! Just few comments and questions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High-level comments and recommendations. Main comments revolve around having duplicated constants everywhere which will make the job of maintaining these tests very hard. Otherwise lgtm, approving pre-emptively as I don't have anything else to add and these can be handled in other PRs. However, I recommend that the constants issues are resolved in this PR.
We need to think about the improvements there since E2E is actually checking out the system as a whole, so we should be careful with what we mock and when we use the real data. |
Adds basic Playwright example
https://youtu.be/r2zEOT_oVVo
Some basic tests:
Need your opinions on what do we improve in this PR and what do we extract to different issues
At the moment, having issues:
mempool
getBTCTipHeight
e2e
outside oftests
to separate Jest and Playwright. There's also "integration" test in between these two -react-testing-library
, that we don't currently use.signPsbt
in our mocked wallet. But it might be better handled inunbonding
/withdrawing
PRCloses #110 and #13