Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refetch UTXOs on unsuccessful staking #64

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

gbarkhatov
Copy link
Contributor

@gbarkhatov gbarkhatov commented Aug 9, 2024

After you try to stake and some error happens, you can "Try again". Modal is closed, UTXOs are refetched.

Video recorded with the cancel button, then removed it. Only "try again" is available: https://youtu.be/-zcJTXIXqng
"No cancel" video: https://youtu.be/ETjAXdqkegE

Closes #63

@gbarkhatov gbarkhatov changed the title fix: Refetch UTXOs on unsecessful staking fix: Refetch UTXOs on unsuccessful staking Aug 9, 2024
Copy link
Member

@vitsalis vitsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although I don't like the huge "try again" button, but having "cancel" there does not make sense. Not the time to make style changes, we can track to improve how it looks later.

@jrwbabylonlab
Copy link
Collaborator

lgtm, although I don't like the huge "try again" button, but having "cancel" there does not make sense. Not the time to make style changes, we can track to improve how it looks later.

Why not just leave with no button, there is a cancel button at the top right anyway. Upon clicking the cancel button, or navigating away from the modal, we shall re-trigger the UTXO fetch

@gbarkhatov gbarkhatov merged commit 0632a17 into main Aug 12, 2024
1 check passed
@gbarkhatov gbarkhatov deleted the fix/utxo-refetch-after-staking branch August 12, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants