Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/Quest) - Fortunate Misunderstandings #21074

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EricksOliveira
Copy link
Contributor

@EricksOliveira EricksOliveira commented Dec 31, 2024

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • [x ] Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • [x ] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • [x ] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • [x ] Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

After the NPC Injured Rainspeaker Oracle = 28217 is escorted to the Rainspeaker Canopy Camp. Complete the Quest Fortunate Misunderstandings = 12570.

  • [x ] This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. .quest add 12570
  2. Speak to Injured Rainspeaker Oracle = 28217
  3. Escort the Injured Rainspeaker Oracle to the Rainspeaker Canopy Camp
  4. Please note that at the end of the route the quest must be completed.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB related to the SQL database label Dec 31, 2024
Copy link
Contributor

@TheSCREWEDSoftware TheSCREWEDSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline at the end in the SQL. Fix your issue description and tells us a little more what are you doing with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fortunate Misunderstandings" Quest Completion Bug in Sholazar Basin
2 participants