SvelteKit SSR zip example #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxfactorial
force-pushed
the
sveltekit-ssr-zip-example
branch
from
e938fb6 to
ebeee63
Compare
mxfactorial
force-pushed
the
sveltekit-ssr-zip-example
branch
from
ebeee63 to
4651035
Compare
|
Thanks for this example! One comment: since you have SAM template in this project, it's better to use Makefile to integrate the build process. You could take a look at the nextjs-zip example to see how it works. Add the following to the function in the SAM template, and create a Makefile to invoke your build script. Metadata:
BuildMethod: makefile |
|
ready |
|
adding one more commit in case a user isnt only using devDependencies |
mxfactorial
force-pushed
the
sveltekit-ssr-zip-example
branch
from
02b09a0 to
9d56630
Compare
|
missed a doc change after the makefile edit adding a commit ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
demos how the adapter can deploy a ssr-enabled sveltekit app without monkey business
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.