Add partial support for Proactive rules #499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Part of #400
Description of changes:
This partially implements issue #400. Config does not support Proactive evaluation modes for Organization rules. Only single-account rules support EvaluationMode arguments.
So, this change allows single-account (non-Organization rules) rules to use proactive evaluation modes.
This will be lumped into the 0.18.0 release. I am not planning to do a 0.17.12 release.
The CLI will have two new options:
rdk create
will support an argument for--evaluation-mode
and store it in theparameters.json
filerdk deploy
(but notdeploy-organization
) will this feature by readingEvaluationMode
fromparameters.json
.In addition to this change, there are a few minor changes lumped in here:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.