More consistent ASCP install option #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirkafajfr
approved these changes
Dec 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
=======================================
Coverage 49.67% 49.67%
=======================================
Files 9 9
Lines 781 781
=======================================
Hits 388 388
Misses 383 383
Partials 10 10 ☔ View full report in Codecov by Sentry. |
|
Thank you @jirkafajfr for the review! |
|
Hi @jirkafajfr hope all is well! Do you know if any steps I'm missing that is blocking the merge? Thanks in advance! |
willtong1234
approved these changes
Dec 23, 2024
ravenfirstmen
pushed a commit
to ravenfirstmen/secrets-store-csi-driver-provider-aws
that referenced
this pull request
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Make the installation progress consistent as the https://docs.aws.amazon.com/secretsmanager/latest/userguide/integrating_csi_driver.html with helm installation option.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.