Move to Go 1.23 #398
Merged
Move to Go 1.23 #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannah-nguyen-ca
approved these changes
Oct 17, 2024
tongshen-stephanie
approved these changes
Oct 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 53.15% 49.67% -3.48%
==========================================
Files 8 9 +1
Lines 730 781 +51
==========================================
Hits 388 388
- Misses 332 383 +51
Partials 10 10 ☔ View full report in Codecov by Sentry. |
simonmarty
commented
Oct 17, 2024
| uses: codecov/codecov-action@v3.1.0 | ||
| uses: codecov/codecov-action@v4 | ||
| env: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Required to not get throttled by CodeCov. Not particularly sensitive (worst case scenario if this leaks is that someone overwrites our code coverage data)
tongshen-stephanie
approved these changes
Oct 17, 2024
ravenfirstmen
pushed a commit
to ravenfirstmen/secrets-store-csi-driver-provider-aws
that referenced
this pull request
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.