Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: affinity rule to ignore Fargate node #247

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ngarciaf
Copy link

Issue #, if available:

Description of changes:

According to the documentation), the ASCP doesn't offer support for Fargate nodes because this kind of node is incompatible with daemonset workloads.
In the context of deploying a hybrid cluster consisting of Fargate-EC2 nodes, it is possible to deploy daemonsets on those EC2 nodes. However, it's important to note that the daemonsets will remain in a "pending" state on the Fargate nodes (due to the mentioned limitation). This recommendation was formulated to include the affinity rule by default in the values file to address this specific scenario. By including this affinity rule in the values file, it helps ensure proper scheduling and allocation of daemonsets only on the EC2 nodes.
Cheers!
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@simonmarty simonmarty added the enhancement New feature or request label Jul 13, 2023
@jbct
Copy link

jbct commented Jul 17, 2023

Thank you for the PR, we have noted this as an enhancement request.

@ngarciaf
Copy link
Author

Thanks for the feedback @jbct

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.15%. Comparing base (1257240) to head (3760221).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   53.15%   53.15%           
=======================================
  Files           8        8           
  Lines         730      730           
=======================================
  Hits          388      388           
  Misses        332      332           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngarciaf ngarciaf requested a review from a team as a code owner February 28, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants