-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AWSLocation): Fixing clock skew retries #5491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
sebaland
temporarily deployed
to
IntegrationTest
January 10, 2025 16:46 — with
GitHub Actions
Inactive
harsh62
approved these changes
Jan 10, 2025
thisisabhash
approved these changes
Jan 10, 2025
cgalvan
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR fixes the retry mechanism when dealing with clock skews in AWSLocation. The logic is actually implemented in the
AWSURLRequestRetryHandler
, but it depends on both the error domain and code to be fromAWSService
itself.Because the
AWSLocation
service defines its own error domain and codes, the conditions were never met andisClockSkewError
always evaluated tofalse
.So I've just added some code to handle cases in which the error can be mapped to a "vanilla"
AWSService
error instead, which then makes the retry mechanism work.Note: This is actually affecting every AWS service that defines its own set of errors and does not override the proper methods in
AWSURLRequestRetryHandler
. It should be fixedCheck points:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.