-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow x-api-key for public rest api #13422
Conversation
Please aws-team I have the problem, I see that is release that problem with x-api-key will be resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
Added some nit-picking and sanity check comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the fix! @ashika112 I only have a few questions.
THANK YOU. ... just like it was BEFORE Jan of 2024. |
Description of changes
We should check only custom
authorization
to override the IAM auth. This bring v6 in parity with v5 feature.V5 Ref:
amplify-js/packages/api-rest/src/RestClient.ts
Line 163 in b88df66
Issue #, if available
#13310
#13378
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.