fixes result parsing for observeQuery, onCreate, onUpdate, and onDelete operations #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 183be1c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
svidgen
commented
Sep 6, 2024
| const { client, spy } = await getMockedClient('getTodo', selectionSet); | ||
| const { client, spy } = await getMockedClient('getTodo'); |
There was a problem hiding this comment.
A few lines here are just cleaning up a param that wasn't ultimately used.
|
Pretty sure this is OK. But, converting back to draft until I can confirm next week that we have tests for the opposite case — if custom selection set is not present, we want to ensure the lazy loaders are created. If test cases for this don't exist, I'll add them next week. Update: New lazy loading tests have been added. |
iartemiev
reviewed
Sep 10, 2024
iartemiev
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Addresses part of this issue: aws-amplify/amplify-js#13267
Description of changes:
Prior to this PR, subscription-like operations incorrectly handled nested models in graphql responses from custom selection sets. These operations would replace child properties with lazy loaders even when relationships were eagerly loaded.
This PR fixes the problem and adds tests to verify for each operation that:
itemsproperties flattenedBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.