Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github): skip free-disk-space action if there are no changed files #5536

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Dec 5, 2024

Description

Even when there were no differences by the changed-files action, the free-disk-space action, which takes several minutes, was still executed.
Screenshot 2024-12-05 at 21 09 46

To reduce costs for the self-hosted runner, the free-disk-space action will also be skipped as the same as the docker-build-and-push action when there are no differences.

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Copy link

github-actions bot commented Dec 5, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk self-assigned this Dec 5, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Dec 5, 2024
@youtalk youtalk marked this pull request as ready for review December 5, 2024 12:11
@youtalk youtalk requested a review from oguzkaganozt as a code owner December 5, 2024 12:11
@youtalk youtalk requested review from xmfcx and mitsudome-r December 5, 2024 12:11
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense 👍

@youtalk youtalk merged commit 302e8b5 into main Dec 5, 2024
40 checks passed
@youtalk youtalk deleted the skip-free-disk-space branch December 5, 2024 13:02
youtalk added a commit to youtalk/autoware that referenced this pull request Dec 19, 2024
* feat(.github): push version tag images (autowarefoundation#5522)

* add tag pattern

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix syntax

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* add tags

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix prefix and suffix

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* feat(.github): add `on:push:branches:` condition to `autoware-base` workflow (autowarefoundation#5524)

add paths arg

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix(.github): not push manifest if eithor `amd64` or `arm64` image is missing (autowarefoundation#5525)

not push manifest if eithor amd64 or arm64 is missing

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* chore(autoware.repos): fix autoware.core commit hash (autowarefoundation#5530)

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

* feat(.git): delete `-amd64` and  `-arm64` image tags after pushing manifest (autowarefoundation#5526)

* not push manifest if eithor amd64 or arm64 is missing

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* delete -amd64 and -arm64 tags

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* chore(.github): skip `free-disk-space` action if there are no changed files (autowarefoundation#5536)

skip free-disk-space action

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* ci: enable bugprone-* warnings in clang-tidy (autowarefoundation#5543)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* feat(autoware.repos): use version tag for sensor_kits (autowarefoundation#5554)

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

* ci(pre-commit-ansible): autoupdate (autowarefoundation#5552)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>

* chore(deps): bump peter-evans/create-pull-request from 6 to 7 (autowarefoundation#5162)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6 to 7.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v6...v7)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci(pre-commit-optional): autoupdate (autowarefoundation#5401)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>

* chore: sync files (autowarefoundation#5541)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>

* chore: sync files (autowarefoundation#5572)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>

* fix(.github): fix CODEOWNERS (autowarefoundation#5575)

Update CODEOWNERS

* fix: update branch of scenario_simulator_v2 to master (autowarefoundation#5570)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(autoware.repos): remove `autoware_common` from `autoware.repos` (autowarefoundation#5578)

* chore(.devcontainer): add `core-devel` development container (autowarefoundation#5574)

add core-devel devcontainer

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
youtalk added a commit to youtalk/autoware that referenced this pull request Dec 20, 2024
… files (autowarefoundation#5536)

skip free-disk-space action

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants