feat(.git): delete -amd64 and -arm64 image tags after pushing manifest
#5526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
youtalk
added
type:containers
|
Are there any reasons for deleting the tag? I thought we can keep it even if after the manifest is pushed. |
|
@mitsudome-r It’s simply a matter of consistency. I found it personally unsettling to see a lot of multi-architecture images alongside single-architecture images with suffixes. |
mitsudome-r
approved these changes
Dec 4, 2024
youtalk
added a commit
to youtalk/autoware
that referenced
this pull request
Dec 19, 2024
* feat(.github): push version tag images (autowarefoundation#5522) * add tag pattern Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix syntax Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * add tags Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix prefix and suffix Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * feat(.github): add `on:push:branches:` condition to `autoware-base` workflow (autowarefoundation#5524) add paths arg Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix(.github): not push manifest if eithor `amd64` or `arm64` image is missing (autowarefoundation#5525) not push manifest if eithor amd64 or arm64 is missing Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * chore(autoware.repos): fix autoware.core commit hash (autowarefoundation#5530) Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * feat(.git): delete `-amd64` and `-arm64` image tags after pushing manifest (autowarefoundation#5526) * not push manifest if eithor amd64 or arm64 is missing Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * delete -amd64 and -arm64 tags Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * chore(.github): skip `free-disk-space` action if there are no changed files (autowarefoundation#5536) skip free-disk-space action Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * ci: enable bugprone-* warnings in clang-tidy (autowarefoundation#5543) Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * feat(autoware.repos): use version tag for sensor_kits (autowarefoundation#5554) Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * ci(pre-commit-ansible): autoupdate (autowarefoundation#5552) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> * chore(deps): bump peter-evans/create-pull-request from 6 to 7 (autowarefoundation#5162) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6 to 7. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v6...v7) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci(pre-commit-optional): autoupdate (autowarefoundation#5401) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> * chore: sync files (autowarefoundation#5541) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> * chore: sync files (autowarefoundation#5572) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> * fix(.github): fix CODEOWNERS (autowarefoundation#5575) Update CODEOWNERS * fix: update branch of scenario_simulator_v2 to master (autowarefoundation#5570) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(autoware.repos): remove `autoware_common` from `autoware.repos` (autowarefoundation#5578) * chore(.devcontainer): add `core-devel` development container (autowarefoundation#5574) add core-devel devcontainer Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
amd64orarm64image is missing #5525This PR deletes the
-amd64and-arm64image tags after the manifest for the multi-architecture image has been pushed.How was this PR tested?
Notes for reviewers
None.
Effects on system behavior
None.