-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): update cleanup scripts #5497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youtalk
added
type:containers
Docker containers, containerization of components, or container orchestration.
component:openadkit
Issues or Features related to Open AD Kit
tag:run-health-check
Run health-check
labels
Nov 27, 2024
The sizes of the container images have finally returned to the normal level they ware at some time ago. |
xmfcx
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
youtalk
force-pushed
the
refine-cleanup-scripts
branch
from
November 28, 2024 12:29
1a8b205
to
39c8a96
Compare
youtalk
added a commit
to youtalk/autoware
that referenced
this pull request
Nov 29, 2024
* feat(docker): inherit `autoware-base` images (autowarefoundation#5492) * change run Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * use autoware-base images Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update health-check Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update load-env Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update load-env Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix rebase Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * add build-args Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix hcl Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * chore(autoware.repos): fix `autoware.universe` and `autoware_launch` versions to `0.39.0` (autowarefoundation#5479) * ci: update the pr template and add comment-on-pr workflow (autowarefoundation#5500) Signed-off-by: M. Fatih Cırıt <mfc@autoware.org> * ci(spell-check): switch the repository to autowarefoundation (autowarefoundation#5501) Signed-off-by: M. Fatih Cırıt <mfc@autoware.org> * ci(pre-commit-ansible): autoupdate (autowarefoundation#5217) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> * ci(spell-check-diff): add explicit dict-packages (autowarefoundation#5503) Signed-off-by: M. Fatih Cırıt <mfc@autoware.org> * refactor(docker): fix `Dockerfile` indent (autowarefoundation#5495) fix indent Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * feat(docker): update cleanup scripts (autowarefoundation#5497) * update cleanup scripts Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * revert to ubuntu-22.04 Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * ci(sync-files): make use of sync-files-templates repo (autowarefoundation#5504) Signed-off-by: M. Fatih Cırıt <mfc@autoware.org> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> Signed-off-by: M. Fatih Cırıt <mfc@autoware.org> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com> Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:openadkit
Issues or Features related to Open AD Kit
tag:run-health-check
Run health-check
type:containers
Docker containers, containerization of components, or container orchestration.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some cases ware discovered where APT cache remains. This PR revises the
cleanup_apt.sh
andcleanup_system.sh
to leverage Docker build cache while preventing unnecessary APT cache from remaining in the container images.Ref.
It was found that this PR reduces the image sizes by up to approximately 3GB.
https://hub.docker.com/repository/docker/youtalk/autoware/tags?name=universe-devel-cuda-2024
Tests performed
https://github.com/autowarefoundation/autoware/actions/runs/12059829503
https://github.com/autowarefoundation/autoware/actions/runs/12047930761
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.