Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): update cleanup scripts #5497

Merged
merged 2 commits into from
Nov 28, 2024
Merged

feat(docker): update cleanup scripts #5497

merged 2 commits into from
Nov 28, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Nov 27, 2024

Description

Some cases ware discovered where APT cache remains. This PR revises the cleanup_apt.sh and cleanup_system.sh to leverage Docker build cache while preventing unnecessary APT cache from remaining in the container images.

Ref.

It was found that this PR reduces the image sizes by up to approximately 3GB.

https://hub.docker.com/repository/docker/youtalk/autoware/tags?name=universe-devel-cuda-2024
Screenshot 2024-11-27 at 18 52 01

Tests performed

https://github.com/autowarefoundation/autoware/actions/runs/12059829503
https://github.com/autowarefoundation/autoware/actions/runs/12047930761

docker run -it --rm -v $PWD/src/universe/autoware.universe/perception/autoware_tensorrt_common:/autoware/src/autoware_tensorrt_common youtalk/autoware:universe-devel-cuda-amd64
root@99064c6be0b3:/autoware# colcon build
Starting >>> autoware_tensorrt_common
Finished <<< autoware_tensorrt_common [9.11s]

Summary: 1 package finished [9.35s]

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@youtalk youtalk self-assigned this Nov 27, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Nov 27, 2024
@youtalk youtalk marked this pull request as ready for review November 27, 2024 11:06
@youtalk youtalk requested review from xmfcx and mitsudome-r November 27, 2024 11:06
@youtalk
Copy link
Member Author

youtalk commented Nov 28, 2024

The sizes of the container images have finally returned to the normal level they ware at some time ago.

https://autowarefoundation.github.io/autoware-ci-metrics/
Screenshot 2024-11-28 at 14 36 23

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk force-pushed the refine-cleanup-scripts branch from 1a8b205 to 39c8a96 Compare November 28, 2024 12:29
@youtalk youtalk changed the base branch from fix-indent to main November 28, 2024 12:30
@youtalk youtalk enabled auto-merge (squash) November 28, 2024 12:30
@youtalk youtalk merged commit 09049a5 into main Nov 28, 2024
18 checks passed
@youtalk youtalk deleted the refine-cleanup-scripts branch November 28, 2024 12:45
youtalk added a commit to youtalk/autoware that referenced this pull request Nov 29, 2024
* feat(docker): inherit `autoware-base`  images (autowarefoundation#5492)

* change run

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* use autoware-base images

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* update health-check

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* update load-env

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* update load-env

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix rebase

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* add build-args

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix hcl

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* chore(autoware.repos): fix `autoware.universe` and `autoware_launch` versions to `0.39.0` (autowarefoundation#5479)

* ci: update the pr template and add comment-on-pr workflow (autowarefoundation#5500)

Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>

* ci(spell-check): switch the repository to autowarefoundation (autowarefoundation#5501)

Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>

* ci(pre-commit-ansible): autoupdate (autowarefoundation#5217)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>

* ci(spell-check-diff): add explicit dict-packages (autowarefoundation#5503)

Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>

* refactor(docker): fix `Dockerfile` indent (autowarefoundation#5495)

fix indent

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* feat(docker): update cleanup scripts (autowarefoundation#5497)

* update cleanup scripts

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* revert to ubuntu-22.04

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* ci(sync-files): make use of sync-files-templates repo (autowarefoundation#5504)

Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com>
Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants