Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): separation from universe-devel stage to universe-localization-mapping-devel stage #5186

Merged
merged 7 commits into from
Sep 6, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Sep 6, 2024

Description

Resolved #5080

This PR separates from universe-devel stage to universe-localization-mapping-devel stage as well as universe-sensing-perception-devel.

See also https://github.com/autowarefoundation/autoware/blob/upstream-universe-localization-mapping-devel/docker/README.md

Tests performed

youtalk#106
https://github.com/youtalk/autoware/actions/runs/10735323773

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit labels Sep 6, 2024
@youtalk youtalk self-assigned this Sep 6, 2024
@youtalk youtalk added the tag:run-health-check Run health-check label Sep 6, 2024
@youtalk youtalk marked this pull request as ready for review September 6, 2024 11:37
This reverts commit 5ecc4cc.
Copy link
Contributor

@oguzkaganozt oguzkaganozt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@youtalk youtalk merged commit b17202b into main Sep 6, 2024
15 checks passed
@youtalk youtalk deleted the upstream-universe-localization-mapping-devel branch September 6, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Split the mapping/localization packages into a separate container
2 participants