Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker_image): use cuda:12.3.0 base image #3995

Closed
wants to merge 1 commit into from

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Nov 15, 2023

Description

Closes:

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx self-assigned this Nov 15, 2023
@xmfcx xmfcx added the type:build Tooling and infrastructure around building the Autoware. label Nov 15, 2023
@xmfcx
Copy link
Contributor Author

xmfcx commented Nov 15, 2023

@xmfcx xmfcx requested a review from oguzkaganozt November 16, 2023 08:21
@xmfcx
Copy link
Contributor Author

xmfcx commented Nov 16, 2023

@oguzkaganozt it seems both on arm64 and amd64 it built correctly. Could you review this PR?

Also they used the cuda base image as shown here: https://github.com/autowarefoundation/autoware/actions/runs/6879506877/job/18711567150#step:5:801

According to here:

push: ${{ github.event_name == 'schedule' || github.ref_name == github.event.repository.default_branch || github.event_name == 'push'}}

It won't push it to the registry unless it was a scheduled job and was on the main branch.

But since it built things correctly, it should be alright.

@xmfcx xmfcx added type:containers Docker containers, containerization of components, or container orchestration. type:build Tooling and infrastructure around building the Autoware. and removed type:build Tooling and infrastructure around building the Autoware. labels Nov 16, 2023
@oguzkaganozt
Copy link
Contributor

I think although it is fine to use the Cuda base image, maybe it is more convenient to use the Ros base image both for cuda and no-cuda images, Imho, this will simplify the base image logic. BTW, even if we use the cuda base image we would still need to download additional cudnn,cusparse, cublas etc. libraries. So using cuda-base does not eliminate the need to download cuda dependencies with ansible.

@xmfcx xmfcx closed this Nov 16, 2023
@xmfcx
Copy link
Contributor Author

xmfcx commented Nov 16, 2023

@xmfcx xmfcx deleted the feat/cuda-12-3-image branch May 30, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:build Tooling and infrastructure around building the Autoware. type:containers Docker containers, containerization of components, or container orchestration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants