Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): using frenet planner to generate lane change path when ego near terminal #9767

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Dec 24, 2024

Description

This PR adds frenet planner to generate candidate path when ego is near terminal.

Related launcher's PR. autowarefoundation/autoware_launch#1290

Related links

Parent Issue:

  • Link

How was this PR tested?

  1. PSIM
  2. Evaluator TIER IV Internal link

Notes for reviewers

None.

ROS Parameter Changes

Additions and removals

Change type Parameter Name Type Default Value Description
Added trajectory.th_prepare_curvature double 0.03 If the maximum curvature of the prepare segment exceeds the threshold, the prepare segment is invalid.
Added frenet.enable bool 0.03 Enable frenet planner if ego is near terminal start.
Added frenet.th_yaw_diff bool 10.0 If the yaw diff between of the prepare segment's end and lane changing segment's start exceed the threshold , the lane changing segment is invalid.
Added frenet.th_curvature_smoothing bool 0.1 Filters and appends target path points with curvature below the threshold to candidate path.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 24, 2024
Copy link

github-actions bot commented Dec 24, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the RT1-5068-lane-change-frenet branch 2 times, most recently from 4cae773 to 11e2774 Compare December 25, 2024 10:45
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 changed the title frenet planner feat(lane_change): using frenet planner to generate lane change path when ego near terminal Dec 26, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 marked this pull request as ready for review December 26, 2024 04:28
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the RT1-5068-lane-change-frenet branch 3 times, most recently from 66b4fe2 to 881afe1 Compare December 27, 2024 02:02
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the RT1-5068-lane-change-frenet branch from 6453e15 to 3253f79 Compare January 5, 2025 23:24
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Jan 6, 2025
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jan 6, 2025
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 6, 2025
const LineString2d & lane_boundary, const Direction direction)
{
const auto distance = (0.5 * common_data_ptr->bpp_param_ptr->vehicle_width + 0.1);
const auto offset = sign<double>(direction) * distance; // invert direction
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double checking, when doing left lane change then we want to offset to the right, and vice versa. Is that correct? Does this logic do that?

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the RT1-5068-lane-change-frenet branch from ab53673 to 5a4a82c Compare January 10, 2025 01:39
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the RT1-5068-lane-change-frenet branch from 5a4a82c to b48770f Compare January 10, 2025 05:57
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 11.82796% with 328 lines in your changes missing coverage. Please review.

Project coverage is 29.35%. Comparing base (4dc7201) to head (441a17f).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ehavior_path_lane_change_module/src/utils/path.cpp 6.57% 208 Missing and 5 partials ⚠️
...vior_path_lane_change_module/src/utils/markers.cpp 0.00% 48 Missing and 2 partials ⚠️
...are_behavior_path_lane_change_module/src/scene.cpp 23.68% 29 Missing ⚠️
...havior_path_lane_change_module/src/utils/utils.cpp 21.42% 21 Missing and 1 partial ⚠️
.../behavior_path_lane_change_module/structs/path.hpp 11.11% 8 Missing ⚠️
...enet_planner/src/frenet_planner/frenet_planner.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9767      +/-   ##
==========================================
- Coverage   29.41%   29.35%   -0.06%     
==========================================
  Files        1446     1448       +2     
  Lines      108365   108731     +366     
  Branches    42232    42462     +230     
==========================================
+ Hits        31872    31921      +49     
- Misses      73408    73720     +312     
- Partials     3085     3090       +5     
Flag Coverage Δ *Carryforward flag
differential 23.63% <11.82%> (?)
total 29.41% <ø> (+<0.01%) ⬆️ Carriedforward from 4dc7201

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

3 participants