Deprecate SF Symbols recipes #396
Open
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-cossey
requested changes
Dec 31, 2024
|
The ideal situation would be for a single recipe to be usable for both 5 and 6 with a simple override variable. This change would enable that on the foigus-recipes side. Would that meet your needs? |
|
As a rule, we typically prefer separate recipes per version without overriding an input var.
This makes it easier for us to maintain and deprecate.
A few times where we’ve had a more generic recipes we have then need to be amended for the later releases.. meaning we need to split.
…________________________________
From: Elliot Jordan ***@***.***>
Sent: Tuesday, December 31, 2024 10:42:50 PM
To: autopkg/dataJAR-recipes ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [autopkg/dataJAR-recipes] Deprecate SF Symbols recipes (PR #396)
The ideal situation would be for a single recipe to be usable for both 5 and 6 with a simple override variable. This change<https://github.com/autopkg/foigus-recipes/compare/master...homebysix:foigus-recipes:sfsymbols5?expand=1> would enable that on the foigus-recipes side. Would that meet your needs?
—
Reply to this email directly, view it on GitHub<#396 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AASZZTTC3CD3S5ZF7PFLX5L2IMMWVAVCNFSM6AAAAABUNACNTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWG42DAOBUGI>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
That change would work but as Ben said, while it's not a hard rule we do find it easier to maintain version specific recipes. Plus that change would also require additional admin effort for those that only care about getting the latest version. I think we're the exception here with needing both, and as such we're happy to maintain the version specific recipes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the version-specific SF Symbols recipes in this repo, which are not sufficiently distinct from other recipes in the AutoPkg org to warrant the extra maintenance they require. The deprecation notice points users to the SFSymbols recipes in foigus-recipes.