Move InvalidExtrinsicsRootProof storage so it is easier to combine later #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested review from
vedhavyas,
NingLin-P,
nazar-pc and
rg3l3dr
as code owners
NingLin-P
approved these changes
Dec 12, 2024
| @@ -414,16 +414,27 @@ impl MaybeDomainRuntimeUpgradedProof { | |||
| } | |||
|
|
|||
| #[derive(Clone, Debug, Decode, Encode, Eq, PartialEq, TypeInfo)] | |||
| pub struct DomainInherentExtrinsicDataProof { | |||
| pub struct InvalidExtrinsicsDataProof { | |||
There was a problem hiding this comment.
Non-blocker but it may be worth having Inherent in the name, to distinguish it from the invalid extrinsic from the invalid bundle fraud proof.
1 task
teor2345
added
the
host-function-change
teor2345
commented
Dec 19, 2024
| @@ -262,6 +262,8 @@ where | |||
| domain_inherent_extrinsic_data: DomainInherentExtrinsicData, | |||
| ) -> Option<DomainInherentExtrinsic> { | |||
| let DomainInherentExtrinsicData { | |||
| // Used by caller | |||
| block_randomness: _, | |||
There was a problem hiding this comment.
This PR contains a host function change, which we are planning to revert in #3314
1 task
teor2345
added a commit
that referenced
this pull request
Dec 19, 2024
teor2345
added
the
breaking-runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactor to prepare for combining storage in #3281. It moves all the storage that will be combined together, and moves out large storage that we won't combine.
In the next PR, I'll combine all the storage proofs in
InvalidExtrinsicsDataProofinto a single storage proof.Breaking changes:
Code contributor checklist: